Skip to content

branch-3.1: [fix](database) Fix rename db and create table race #55054 #55991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Sep 19, 2025
Merged

branch-3.1: [fix](database) Fix rename db and create table race #55054 #55991

morrySnow merged 2 commits into from
Sep 19, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Sep 12, 2025 •
edited by morrySnow
Loading

picked from #55054

@deardeng deardeng requested a review from morrySnow as a code owner September 12, 2025 14:22
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

deardeng commented Sep 12, 2025

run buildall

@deardeng
[fix](database) Fix rename db and create table race (apache#55054)
871af42 
Add db lock to protect rename db editlog, and when writing create table
editlog, check whether the db name has been modified. If the db name has
been modified, the table creation statement will report an error.
@deardeng
fix rebase compile
f3d22cf
@deardeng deardeng force-pushed the pick_55054_to_doris_branch-3.1 branch from 07155e3 to f3d22cf Compare September 18, 2025 08:17
@deardeng
Copy link
Contributor Author

deardeng commented Sep 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 18, 2025

TPC-H: Total hot run time: 32672 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f3d22cf8e7195c2373d546fa9feb1a480b931436, data reload: false

------ Round 1 ----------------------------------
q1	17641	5504	5447	5447
q2	2026	400	303	303
q3	12369	1293	783	783
q4	10539	877	461	461
q5	9660	2375	2131	2131
q6	194	164	136	136
q7	919	766	611	611
q8	9343	1434	1177	1177
q9	5271	5001	4899	4899
q10	6765	2242	1816	1816
q11	485	288	279	279
q12	343	355	211	211
q13	17772	3615	2983	2983
q14	245	233	215	215
q15	539	475	455	455
q16	419	426	366	366
q17	629	861	375	375
q18	6627	6369	6312	6312
q19	1218	960	570	570
q20	332	350	205	205
q21	2907	2215	1963	1963
q22	1032	1040	974	974
Total cold run time: 107275 ms
Total hot run time: 32672 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5563	5491	5483	5483
q2	236	330	245	245
q3	2232	2642	2335	2335
q4	1449	1829	1388	1388
q5	4386	5039	4993	4993
q6	168	159	130	130
q7	2015	1934	1822	1822
q8	2590	2820	2691	2691
q9	7271	7236	7253	7236
q10	3024	3332	2707	2707
q11	559	508	497	497
q12	664	773	559	559
q13	3421	3801	3162	3162
q14	281	298	294	294
q15	516	471	454	454
q16	455	478	452	452
q17	1234	1740	1268	1268
q18	7630	7428	7356	7356
q19	806	967	1162	967
q20	2057	2051	1909	1909
q21	5359	4882	4604	4604
q22	1074	1051	995	995
Total cold run time: 52990 ms
Total hot run time: 51547 ms

@doris-robot
Copy link

doris-robot commented Sep 18, 2025

TPC-DS: Total hot run time: 194532 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f3d22cf8e7195c2373d546fa9feb1a480b931436, data reload: false

query1	977	400	398	398
query2	6213	2028	1910	1910
query3	8684	206	204	204
query4	33602	24253	23853	23853
query5	4686	611	462	462
query6	320	202	190	190
query7	4238	515	314	314
query8	305	270	234	234
query9	9450	2620	2607	2607
query10	488	334	266	266
query11	18133	15473	15370	15370
query12	159	108	105	105
query13	1589	567	444	444
query14	10422	7025	7208	7025
query15	226	191	187	187
query16	8041	660	490	490
query17	1426	801	606	606
query18	2165	408	343	343
query19	223	205	174	174
query20	136	128	129	128
query21	207	130	108	108
query22	4562	4496	4427	4427
query23	35273	34518	34372	34372
query24	7482	2754	2760	2754
query25	505	476	434	434
query26	1171	276	175	175
query27	2216	505	358	358
query28	5302	2241	2255	2241
query29	626	597	476	476
query30	244	193	176	176
query31	1040	950	850	850
query32	92	68	63	63
query33	529	381	358	358
query34	766	874	529	529
query35	787	812	745	745
query36	1048	1096	972	972
query37	113	100	78	78
query38	4063	4081	4038	4038
query39	1534	1492	1466	1466
query40	215	121	106	106
query41	50	48	47	47
query42	129	111	112	111
query43	533	533	494	494
query44	1341	845	859	845
query45	193	180	174	174
query46	898	1064	687	687
query47	1985	1964	1928	1928
query48	397	434	357	357
query49	771	496	421	421
query50	676	688	455	455
query51	7339	7318	7234	7234
query52	104	104	96	96
query53	243	265	204	204
query54	577	567	486	486
query55	88	80	80	80
query56	262	295	270	270
query57	1270	1263	1218	1218
query58	235	223	220	220
query59	3124	3290	3320	3290
query60	311	287	266	266
query61	117	116	116	116
query62	819	754	709	709
query63	255	210	205	205
query64	4591	1022	700	700
query65	3429	3391	3424	3391
query66	1073	420	319	319
query67	16949	15833	15480	15480
query68	7686	840	562	562
query69	478	311	276	276
query70	1204	1159	1139	1139
query71	428	301	277	277
query72	5089	4014	3815	3815
query73	660	747	361	361
query74	10311	9455	9197	9197
query75	3865	3182	2672	2672
query76	3558	1164	769	769
query77	791	376	275	275
query78	10222	10410	9668	9668
query79	5493	868	613	613
query80	655	534	440	440
query81	490	267	225	225
query82	235	119	98	98
query83	168	165	145	145
query84	290	107	87	87
query85	758	397	303	303
query86	353	297	298	297
query87	4373	4362	4259	4259
query88	4508	2447	2537	2447
query89	435	338	302	302
query90	2047	195	195	195
query91	139	154	113	113
query92	62	57	50	50
query93	3645	898	558	558
query94	656	411	286	286
query95	350	286	283	283
query96	495	624	290	290
query97	3198	3267	3181	3181
query98	215	214	199	199
query99	1464	1383	1311	1311
Total cold run time: 301338 ms
Total hot run time: 194532 ms

@doris-robot
Copy link

doris-robot commented Sep 18, 2025

ClickBench: Total hot run time: 30.06 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f3d22cf8e7195c2373d546fa9feb1a480b931436, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.64	0.10	0.10
query5	0.52	0.52	0.53
query6	1.14	0.75	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.49
query10	0.55	0.55	0.56
query11	0.15	0.11	0.10
query12	0.13	0.10	0.11
query13	0.62	0.59	0.60
query14	0.79	0.82	0.83
query15	0.84	0.84	0.83
query16	0.38	0.41	0.38
query17	1.03	1.09	1.04
query18	0.24	0.21	0.22
query19	1.98	1.93	1.85
query20	0.01	0.01	0.01
query21	15.38	0.89	0.57
query22	0.74	0.84	0.85
query23	14.91	1.48	0.61
query24	3.26	1.72	1.78
query25	0.15	0.19	0.19
query26	0.28	0.14	0.15
query27	0.06	0.04	0.05
query28	14.21	0.97	0.43
query29	12.59	3.93	3.25
query30	0.25	0.09	0.06
query31	2.83	0.60	0.38
query32	3.24	0.54	0.47
query33	2.96	3.09	3.01
query34	16.58	5.23	4.57
query35	4.63	4.62	4.54
query36	0.65	0.50	0.47
query37	0.10	0.05	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.2 s
Total hot run time: 30.06 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 19, 2025

FE UT Coverage Report

Increment line coverage 36.36% (12/33) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow changed the title [fix](database) Fix rename db and create table race (#55054) branch-3.1: [fix](database) Fix rename db and create table race #55054 Sep 19, 2025
@morrySnow morrySnow merged commit 609aad3 into apache:branch-3.1 Sep 19, 2025
22 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deardeng @hello-stephen @doris-robot @morrySnow