Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

What problem does this PR solve?

This pull request refines the logic for detecting aggregate columns in materialized view creation, particularly in the context of different key types. The main change is that the hasAggregateSlot method now considers the materialized view's key type, which improves accuracy when checking for unsupported aggregate columns in WHERE clauses. The test suite is also updated to cover scenarios involving unique keys.

Improvements to aggregate column detection:

  • Updated the hasAggregateSlot method in Expr and its override in SlotRef to accept a KeysType parameter, allowing the method to behave differently based on the key type of the materialized view. [1] [2]
  • Modified calls to hasAggregateSlot in CreateMaterializedViewStmt to pass the current materialized view key type, ensuring correct validation logic for WHERE clauses and column definitions. [1] [2]

Test coverage enhancements:

  • Added new test cases in k123.groovy to validate materialized view creation with unique keys and ensure that aggregate columns in WHERE clauses are correctly detected and rejected.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 14.29% (1/7) 🎉
Increment coverage report
Complete coverage report

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 14.29% (1/7) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants