-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Bug](mv)forbid create mv with condition about value column on mow table #57913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BiteTheDDDDt
wants to merge
3
commits into
apache:branch-3.0
Choose a base branch
from
BiteTheDDDDt:fix_1111_2
base: branch-3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
morrySnow
pushed a commit
that referenced
this pull request
Nov 25, 2025
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request refines the logic for detecting aggregate columns in materialized view creation, particularly in the context of different key types. The main change is that the
hasAggregateSlotmethod now considers the materialized view's key type, which improves accuracy when checking for unsupported aggregate columns in WHERE clauses. The test suite is also updated to cover scenarios involving unique keys.Improvements to aggregate column detection:
hasAggregateSlotmethod inExprand its override inSlotRefto accept aKeysTypeparameter, allowing the method to behave differently based on the key type of the materialized view. [1] [2]hasAggregateSlotinCreateMaterializedViewStmtto pass the current materialized view key type, ensuring correct validation logic for WHERE clauses and column definitions. [1] [2]Test coverage enhancements:
k123.groovyto validate materialized view creation with unique keys and ensure that aggregate columns in WHERE clauses are correctly detected and rejected.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)