Skip to content

[Bug](mv)forbid create mv with condition about value column on mow table #57913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BiteTheDDDDt wants to merge 3 commits into
base: branch-3.0
Choose a base branch
from
+36 −5
Open

[Bug](mv)forbid create mv with condition about value column on mow table #57913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e1f72c
forbid create mv with condition about value column on mow table
BiteTheDDDDt Nov 11, 2025
668594c
update
BiteTheDDDDt Nov 11, 2025
03d21ff
update
BiteTheDDDDt Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ public void analyze(Analyzer analyzer) throws UserException {
mvKeysType = KeysType.AGG_KEYS;
}
if (selectStmt.getWhereClause() != null) {
if (!isReplay && selectStmt.getWhereClause().hasAggregateSlot()) {
if (!isReplay && selectStmt.getWhereClause().hasAggregateSlot(getMVKeysType())) {
throw new AnalysisException(
"The where clause contained aggregate column is not supported, expr:"
+ selectStmt.getWhereClause().toSql());
Expand Down Expand Up @@ -582,7 +582,7 @@ private MVColumnItem buildMVColumnItem(Analyzer analyzer, FunctionCallExpr funct
mvAggregateType = AggregateType.valueOf(functionName.toUpperCase());
}

if (!isReplay && defineExpr.hasAggregateSlot()) {
if (!isReplay && defineExpr.hasAggregateSlot(getMVKeysType())) {
SlotRef slot = null;
if (defineExpr instanceof SlotRef) {
slot = (SlotRef) defineExpr;
Expand Down
5 changes: 3 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.doris.catalog.Function;
import org.apache.doris.catalog.Function.NullableMode;
import org.apache.doris.catalog.FunctionSet;
import org.apache.doris.catalog.KeysType;
import org.apache.doris.catalog.MapType;
import org.apache.doris.catalog.MaterializedIndexMeta;
import org.apache.doris.catalog.PrimitiveType;
Expand Down Expand Up @@ -2271,9 +2272,9 @@ protected static boolean hasNullableChild(List<Expr> children) {
return false;
}

public boolean hasAggregateSlot() {
public boolean hasAggregateSlot(KeysType keysType) {
for (Expr expr : children) {
if (expr.hasAggregateSlot()) {
if (expr.hasAggregateSlot(keysType)) {
return true;
}
}
Expand Down
9 changes: 8 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.JdbcTable;
import org.apache.doris.catalog.KeysType;
import org.apache.doris.catalog.MaterializedIndexMeta;
import org.apache.doris.catalog.OdbcTable;
import org.apache.doris.catalog.TableIf;
Expand Down Expand Up @@ -499,7 +500,13 @@ public boolean isBoundByTupleIds(List<TupleId> tids) {
}

@Override
public boolean hasAggregateSlot() {
public boolean hasAggregateSlot(KeysType keysType) {
if (KeysType.UNIQUE_KEYS.equals(keysType)) {
Column column = getColumn();
if (column != null && !column.isKey()) {
return true;
}
}
return desc.getColumn().isAggregated();
}

Expand Down
23 changes: 23 additions & 0 deletions regression-test/suites/mv_p0/where/k123/k123.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,27 @@ suite ("k123p") {

mv_rewrite_success("""select k1,k2+k3 from d_table where k1 = 2 and k4 = "b";""", "k123p4w")

sql """ DROP TABLE IF EXISTS u_table; """
sql """
create table u_table(
k1 int null,
k2 int not null,
k3 bigint null,
k4 varchar(100) null
)
unique key (k1,k2)
distributed BY hash(k1) buckets 3
properties("replication_num" = "1");
"""

sql "insert into u_table select 1,1,1,'a';"
sql "insert into u_table select 2,2,2,'bb';"
sql "insert into u_table select 3,-3,null,'c';"

test {
sql """create materialized view k123p4w as select k1 as aa1,k2 as aa2,k3 as aa3 from u_table where k4 = "b";"""
exception "The where clause contained aggregate column is not supported"
}

createMV ("""create materialized view k123p1w as select k1 as a1,k2 as a2,k3 as a3 from u_table where k1 = 1;""")
}
Loading