Skip to content

[fix](auth)Fixed the issue nereids not check for the existence of permission items #58282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 3 commits into from
Nov 25, 2025
Merged

[fix](auth)Fixed the issue nereids not check for the existence of permission items #58282

starocean999 merged 3 commits into from
Nov 25, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Nov 24, 2025 •
edited
Loading

What problem does this PR solve?

Fixed the issue where the new optimizer did not check for the existence of permission items, resulting in unclear error messages

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Nov 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

TPC-H: Total hot run time: 34629 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fcfbe7dfeb24a372e38a9d809b0a973751988c59, data reload: false

------ Round 1 ----------------------------------
q1	17607	5080	4956	4956
q2	2017	310	207	207
q3	10266	1299	718	718
q4	10236	966	390	390
q5	7469	2404	2362	2362
q6	187	176	142	142
q7	913	778	626	626
q8	9354	1324	1115	1115
q9	7161	5492	5358	5358
q10	6838	2250	1831	1831
q11	495	300	285	285
q12	338	363	224	224
q13	17769	3722	3074	3074
q14	241	237	217	217
q15	605	515	509	509
q16	1026	1007	941	941
q17	593	874	361	361
q18	7497	7197	7228	7197
q19	1258	975	582	582
q20	360	345	232	232
q21	3840	3225	2311	2311
q22	1053	996	991	991
Total cold run time: 107123 ms
Total hot run time: 34629 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4968	4941	5031	4941
q2	325	407	315	315
q3	2154	2725	2281	2281
q4	1320	1781	1360	1360
q5	4272	4537	4620	4537
q6	230	184	134	134
q7	2073	1994	1847	1847
q8	2658	2652	2598	2598
q9	7794	7625	7906	7625
q10	3036	3221	2835	2835
q11	584	532	531	531
q12	705	743	605	605
q13	3660	3948	3256	3256
q14	279	314	289	289
q15	552	508	512	508
q16	1094	1096	1065	1065
q17	1178	1567	1363	1363
q18	7849	7769	7664	7664
q19	820	831	888	831
q20	2015	2114	1932	1932
q21	4990	4430	4306	4306
q22	1090	1018	1021	1018
Total cold run time: 53646 ms
Total hot run time: 51841 ms

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

TPC-DS: Total hot run time: 186810 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fcfbe7dfeb24a372e38a9d809b0a973751988c59, data reload: false

query1	1021	404	392	392
query2	6569	1680	1680	1680
query3	6776	231	220	220
query4	25659	23267	22822	22822
query5	4422	644	491	491
query6	335	239	226	226
query7	4647	504	308	308
query8	321	272	252	252
query9	8717	2608	2640	2608
query10	503	339	301	301
query11	15543	15123	14787	14787
query12	175	116	111	111
query13	1690	591	488	488
query14	11079	9388	9406	9388
query15	211	190	179	179
query16	7720	698	535	535
query17	1254	793	643	643
query18	2040	442	343	343
query19	228	209	180	180
query20	137	127	119	119
query21	219	142	117	117
query22	4019	4178	3847	3847
query23	34254	33232	32933	32933
query24	8457	2396	2406	2396
query25	608	556	486	486
query26	1235	279	170	170
query27	2746	495	348	348
query28	4330	2202	2189	2189
query29	795	606	490	490
query30	297	223	198	198
query31	911	821	718	718
query32	86	71	69	69
query33	584	363	312	312
query34	779	856	508	508
query35	802	838	730	730
query36	946	1009	880	880
query37	125	117	84	84
query38	3544	3590	3480	3480
query39	1472	1420	1403	1403
query40	227	133	117	117
query41	63	61	64	61
query42	126	109	113	109
query43	496	493	441	441
query44	1230	765	757	757
query45	188	181	174	174
query46	875	988	634	634
query47	1733	1813	1705	1705
query48	391	428	320	320
query49	787	538	392	392
query50	642	683	421	421
query51	3859	4160	3952	3952
query52	111	108	105	105
query53	233	261	197	197
query54	292	325	280	280
query55	85	84	86	84
query56	322	320	317	317
query57	1171	1168	1106	1106
query58	292	271	269	269
query59	2502	2691	2448	2448
query60	357	340	322	322
query61	162	163	168	163
query62	795	735	663	663
query63	226	193	194	193
query64	4446	1186	874	874
query65	4029	3921	3970	3921
query66	1120	451	334	334
query67	15444	15173	14780	14780
query68	8486	974	620	620
query69	491	316	292	292
query70	1363	1260	1322	1260
query71	500	351	315	315
query72	6063	4987	4962	4962
query73	693	622	364	364
query74	8853	9210	8635	8635
query75	3904	3325	2809	2809
query76	3785	1141	729	729
query77	804	409	312	312
query78	9450	9531	8886	8886
query79	2578	812	604	604
query80	711	606	492	492
query81	492	264	233	233
query82	445	157	141	141
query83	303	273	249	249
query84	313	123	99	99
query85	926	492	458	458
query86	387	313	312	312
query87	3751	3726	3647	3647
query88	3512	2232	2218	2218
query89	398	331	295	295
query90	1862	215	210	210
query91	169	168	133	133
query92	82	71	62	62
query93	1929	989	676	676
query94	713	453	325	325
query95	410	319	304	304
query96	479	564	280	280
query97	2924	3002	2851	2851
query98	238	219	219	219
query99	1401	1386	1248	1248
Total cold run time: 275875 ms
Total hot run time: 186810 ms

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

ClickBench: Total hot run time: 27.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fcfbe7dfeb24a372e38a9d809b0a973751988c59, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.11	0.12
query5	0.26	0.26	0.25
query6	1.18	0.64	0.63
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.57	0.52	0.51
query10	0.57	0.57	0.55
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.59
query14	0.99	1.01	1.00
query15	0.86	0.83	0.83
query16	0.38	0.40	0.42
query17	1.07	1.03	1.04
query18	0.22	0.20	0.19
query19	1.94	1.82	1.80
query20	0.02	0.01	0.01
query21	15.45	0.21	0.13
query22	4.96	0.07	0.05
query23	15.67	0.26	0.10
query24	2.87	0.69	0.95
query25	0.08	0.06	0.05
query26	0.15	0.13	0.13
query27	0.06	0.06	0.05
query28	5.24	1.15	0.93
query29	12.60	3.96	3.25
query30	0.29	0.13	0.12
query31	2.82	0.59	0.38
query32	3.23	0.56	0.48
query33	2.99	3.04	3.09
query34	15.77	5.24	4.57
query35	4.59	4.56	4.59
query36	0.67	0.50	0.48
query37	0.10	0.07	0.07
query38	0.07	0.05	0.03
query39	0.04	0.02	0.03
query40	0.18	0.14	0.15
query41	0.09	0.04	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.07 s
Total hot run time: 27.73 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 24, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit b378078 into apache:master Nov 25, 2025
33 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2025
@zddr
[fix](auth)Fixed the issue nereids not check for the existence of per…
db3df8f 
…mission items (#58282)

Fixed the issue where the new optimizer did not check for the existence
of permission items, resulting in unclear error messages
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 25, 2025
@github-actions @zddr
branch-4.0: [fix](auth)Fixed the issue nereids not check for the exis…
f36b238 
…tence of permission items #58282 (#58325)

Cherry-picked from #58282

Co-authored-by: zhangdong <zhangdong@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@zddr @nagisa-kunhah
[fix](auth)Fixed the issue nereids not check for the existence of per…
c1099c6 
…mission items (apache#58282)

Fixed the issue where the new optimizer did not check for the existence
of permission items, resulting in unclear error messages
@Gabriel39 Gabriel39 mentioned this pull request Jan 13, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 14, 2026
@Gabriel39
[branch-4.0]Pick predicates-related PR (#59804)
0174967 
### What problem does this PR solve?

pick #57397 #58283 #58290 #58282 #58832 #58905 #58960 #59005 #59088
#59098 #59126 #59187 #59581 #59625 #59775

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zddr @hello-stephen @doris-robot @starocean999 @morrySnow @yiguolei