Skip to content

[refactor](predicate) Disable predicates push down for cast expr #58960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 2 commits into from
Dec 12, 2025
Merged

[refactor](predicate) Disable predicates push down for cast expr #58960

Gabriel39 merged 2 commits into from
Dec 12, 2025

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Dec 11, 2025 •
edited
Loading

What problem does this PR solve?

Disable push down all cast expr to avoid tricky value conversion in column predicates.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Dec 11, 2025

run buildall

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Dec 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 12, 2025

TPC-H: Total hot run time: 35385 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit edaf984a77de2cfc9bae4ef8b5443509f85e6b2c, data reload: false

------ Round 1 ----------------------------------
q1	17659	4233	4071	4071
q2	2014	352	244	244
q3	10180	1319	749	749
q4	10258	940	329	329
q5	7560	2218	1910	1910
q6	218	176	141	141
q7	1004	892	717	717
q8	9378	1484	1166	1166
q9	7177	5413	5351	5351
q10	6846	2410	1955	1955
q11	533	327	317	317
q12	694	723	594	594
q13	17800	3676	3059	3059
q14	286	308	288	288
q15	606	516	517	516
q16	933	931	883	883
q17	714	815	518	518
q18	7451	7359	7113	7113
q19	1101	975	639	639
q20	429	353	256	256
q21	4237	4021	3613	3613
q22	1029	987	956	956
Total cold run time: 108107 ms
Total hot run time: 35385 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4370	4037	4075	4037
q2	321	386	319	319
q3	2124	2691	2310	2310
q4	1319	1790	1286	1286
q5	4258	4903	4749	4749
q6	223	185	137	137
q7	2058	1915	1813	1813
q8	2676	2500	2503	2500
q9	7671	7424	7580	7424
q10	3044	3304	2879	2879
q11	581	531	496	496
q12	857	764	572	572
q13	3580	4047	3312	3312
q14	300	304	291	291
q15	556	518	537	518
q16	915	957	886	886
q17	1224	1610	1433	1433
q18	8211	7748	7649	7649
q19	968	877	936	877
q20	1951	2033	1823	1823
q21	4660	4336	4199	4199
q22	1068	1075	957	957
Total cold run time: 52935 ms
Total hot run time: 50467 ms

@doris-robot
Copy link

doris-robot commented Dec 12, 2025

TPC-DS: Total hot run time: 180916 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit edaf984a77de2cfc9bae4ef8b5443509f85e6b2c, data reload: false

query5	4825	633	491	491
query6	335	231	213	213
query7	4232	483	267	267
query8	307	261	230	230
query9	8789	2588	2567	2567
query10	461	372	327	327
query11	15314	15398	14430	14430
query12	177	116	112	112
query13	1257	513	405	405
query14	6345	3235	2997	2997
query14_1	2904	2866	2870	2866
query15	206	202	192	192
query16	880	479	476	476
query17	1135	731	611	611
query18	2585	448	347	347
query19	234	228	210	210
query20	123	112	110	110
query21	220	141	114	114
query22	3958	3960	3889	3889
query23	16548	16151	15866	15866
query23_1	16064	15912	15948	15912
query24	7328	1686	1266	1266
query24_1	1256	1227	1240	1227
query25	588	499	452	452
query26	1262	275	176	176
query27	2731	478	321	321
query28	4498	2158	2144	2144
query29	834	585	472	472
query30	306	242	217	217
query31	827	725	618	618
query32	78	73	81	73
query33	564	335	292	292
query34	939	887	538	538
query35	813	819	734	734
query36	869	907	828	828
query37	139	102	83	83
query38	3798	3802	3861	3802
query39	766	729	723	723
query39_1	712	705	711	705
query40	226	142	136	136
query41	75	68	71	68
query42	110	110	109	109
query43	426	445	414	414
query44	1361	764	758	758
query45	198	193	187	187
query46	898	987	615	615
query47	1642	1698	1602	1602
query48	340	333	274	274
query49	647	455	369	369
query50	683	291	239	239
query51	3858	3884	3820	3820
query52	111	112	104	104
query53	327	361	299	299
query54	313	277	263	263
query55	82	120	72	72
query56	293	311	303	303
query57	1149	1174	1092	1092
query58	271	258	255	255
query59	2341	2405	2350	2350
query60	319	307	291	291
query61	168	160	157	157
query62	737	658	625	625
query63	328	293	306	293
query64	4918	1326	1022	1022
query65	4046	3909	3934	3909
query66	1425	448	324	324
query67	15220	15060	14761	14761
query68	8207	1013	745	745
query69	500	350	312	312
query70	1142	996	969	969
query71	364	301	286	286
query72	6076	4948	4976	4948
query73	673	588	305	305
query74	8870	8714	8579	8579
query75	3569	3543	3135	3135
query76	3960	1170	806	806
query77	567	402	297	297
query78	9409	9633	8976	8976
query79	1276	876	632	632
query80	693	669	550	550
query81	494	271	233	233
query82	224	131	106	106
query83	264	264	239	239
query84	265	120	100	100
query85	933	519	478	478
query86	374	297	287	287
query87	3999	4077	3899	3899
query88	3214	2282	2269	2269
query89	468	416	394	394
query90	2189	161	152	152
query91	177	169	151	151
query92	81	68	63	63
query93	1248	904	575	575
query94	486	295	289	289
query95	559	388	313	313
query96	605	464	215	215
query97	2578	2672	2565	2565
query98	209	205	195	195
query99	1251	1279	1221	1221
Total cold run time: 262518 ms
Total hot run time: 180916 ms

@doris-robot
Copy link

doris-robot commented Dec 12, 2025

ClickBench: Total hot run time: 27.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit edaf984a77de2cfc9bae4ef8b5443509f85e6b2c, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.11	0.11
query5	0.27	0.26	0.26
query6	1.16	0.65	0.63
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.57	0.52	0.49
query10	0.55	0.56	0.56
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.60	0.60
query14	0.98	0.99	0.97
query15	0.82	0.80	0.80
query16	0.41	0.39	0.42
query17	0.99	1.07	1.00
query18	0.23	0.21	0.21
query19	1.81	1.86	1.85
query20	0.02	0.01	0.01
query21	15.44	0.28	0.15
query22	4.84	0.05	0.05
query23	16.06	0.29	0.10
query24	0.93	0.72	0.19
query25	0.10	0.08	0.08
query26	0.15	0.14	0.13
query27	0.08	0.05	0.06
query28	3.53	1.23	1.03
query29	12.62	3.98	3.23
query30	0.28	0.14	0.12
query31	2.81	0.64	0.39
query32	3.24	0.56	0.46
query33	3.06	2.99	3.05
query34	17.03	5.23	4.49
query35	4.60	4.50	4.55
query36	0.67	0.50	0.49
query37	0.10	0.06	0.06
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.17	0.15	0.12
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 96.83 s
Total hot run time: 27.15 s

@doris-robot
Copy link

doris-robot commented Dec 12, 2025

BE UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.42% (18822/35236)
Line Coverage 39.16% (174005/444347)
Region Coverage 33.82% (134792/398586)
Branch Coverage 34.75% (57988/166870)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 12, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.37% (24990/34533)
Line Coverage 59.14% (262474/443849)
Region Coverage 54.10% (218159/403269)
Branch Coverage 55.66% (93352/167724)

eldenmoon
eldenmoon approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit c1c78bf into apache:master Dec 12, 2025
27 of 29 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@Gabriel39 @nagisa-kunhah
[refactor](predicate) Disable predicates push down for cast expr (apa…
3caae4f 
…che#58960)

Disable push down all `cast` expr to avoid tricky value conversion in
column predicates.
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Jan 13, 2026
@Gabriel39
[refactor](predicate) Disable predicates push down for cast expr (apa…
a55542e 
…che#58960)

Disable push down all `cast` expr to avoid tricky value conversion in
column predicates.
@Gabriel39 Gabriel39 mentioned this pull request Jan 13, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 14, 2026
@Gabriel39
[branch-4.0]Pick predicates-related PR (#59804)
0174967 
### What problem does this PR solve?

pick #57397 #58283 #58290 #58282 #58832 #58905 #58960 #59005 #59088
#59098 #59126 #59187 #59581 #59625 #59775

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gabriel39 @hello-stephen @doris-robot @eldenmoon @zhangstar333 @yiguolei