Skip to content

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Nov 27, 2025

What problem does this PR solve?

Fix immutable map removeIf throw UnsupportedOperationException

introduce by #57537

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34427 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b1c2c317cff3616e2886ee5814303420bdd0d089, data reload: false

------ Round 1 ----------------------------------
q1	17603	5065	4938	4938
q2	2053	320	205	205
q3	10262	1294	751	751
q4	10244	966	377	377
q5	7543	2535	2213	2213
q6	196	171	140	140
q7	969	800	646	646
q8	9361	1330	1069	1069
q9	6923	5348	5335	5335
q10	6884	2249	1792	1792
q11	513	308	286	286
q12	371	370	224	224
q13	17790	3648	3042	3042
q14	239	240	225	225
q15	592	522	525	522
q16	1048	1026	985	985
q17	608	736	525	525
q18	7357	7058	6981	6981
q19	1239	947	589	589
q20	347	340	227	227
q21	3597	3182	2437	2437
q22	1017	995	918	918
Total cold run time: 106756 ms
Total hot run time: 34427 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5014	4948	4928	4928
q2	335	403	315	315
q3	2116	2635	2312	2312
q4	1330	1743	1289	1289
q5	4204	4390	4525	4390
q6	221	184	133	133
q7	2015	2015	1774	1774
q8	2805	2470	2491	2470
q9	7555	7376	7473	7376
q10	3060	3268	2818	2818
q11	589	512	491	491
q12	684	719	608	608
q13	3538	3904	3343	3343
q14	293	322	306	306
q15	538	512	512	512
q16	1106	1147	1102	1102
q17	1181	1469	1407	1407
q18	7897	7860	7546	7546
q19	853	768	781	768
q20	1983	2032	1824	1824
q21	4607	4225	4171	4171
q22	1063	1026	992	992
Total cold run time: 52987 ms
Total hot run time: 50875 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185104 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b1c2c317cff3616e2886ee5814303420bdd0d089, data reload: false

query1	1055	411	400	400
query2	6628	1606	1579	1579
query3	6759	233	236	233
query4	25395	23273	23104	23104
query5	5181	627	488	488
query6	342	251	225	225
query7	4656	512	307	307
query8	318	260	244	244
query9	8741	2607	2613	2607
query10	562	362	310	310
query11	15542	15320	14930	14930
query12	176	128	114	114
query13	1705	587	443	443
query14	10980	8885	8865	8865
query15	212	203	185	185
query16	7593	720	533	533
query17	1215	782	635	635
query18	2037	450	355	355
query19	217	219	188	188
query20	136	125	128	125
query21	259	140	121	121
query22	3834	3971	3790	3790
query23	32688	31931	32138	31931
query24	8564	2404	2394	2394
query25	612	550	445	445
query26	735	274	162	162
query27	2684	494	357	357
query28	4264	2147	2120	2120
query29	735	620	501	501
query30	306	238	206	206
query31	800	722	622	622
query32	81	77	74	74
query33	639	382	338	338
query34	831	886	545	545
query35	803	828	766	766
query36	878	953	845	845
query37	121	111	88	88
query38	3297	3317	3270	3270
query39	1457	1433	1420	1420
query40	229	132	122	122
query41	66	61	62	61
query42	123	117	110	110
query43	439	440	421	421
query44	1317	766	755	755
query45	196	187	188	187
query46	885	1012	646	646
query47	1695	1720	1678	1678
query48	398	434	330	330
query49	748	505	395	395
query50	683	695	418	418
query51	3941	3892	3853	3853
query52	125	114	107	107
query53	258	264	198	198
query54	309	307	275	275
query55	95	96	97	96
query56	335	342	338	338
query57	1165	1165	1082	1082
query58	289	282	284	282
query59	2342	2393	2332	2332
query60	355	348	348	348
query61	161	160	162	160
query62	790	743	657	657
query63	232	201	203	201
query64	3322	1213	965	965
query65	4060	4002	3979	3979
query66	939	468	367	367
query67	15092	14890	15196	14890
query68	7590	967	636	636
query69	541	360	321	321
query70	1283	1213	1244	1213
query71	440	355	326	326
query72	5854	4849	4711	4711
query73	652	572	348	348
query74	8817	8931	8618	8618
query75	3338	3354	2820	2820
query76	3221	1146	733	733
query77	495	414	333	333
query78	9450	9671	8889	8889
query79	2286	838	589	589
query80	640	569	494	494
query81	530	268	241	241
query82	343	159	134	134
query83	280	279	268	268
query84	267	119	103	103
query85	909	488	456	456
query86	387	299	284	284
query87	3530	3469	3373	3373
query88	4212	2300	2309	2300
query89	399	340	299	299
query90	2001	234	219	219
query91	172	175	146	146
query92	93	74	68	68
query93	1951	1036	670	670
query94	736	433	333	333
query95	520	418	409	409
query96	524	562	289	289
query97	2907	3001	2912	2912
query98	251	217	211	211
query99	1320	1393	1240	1240
Total cold run time: 269566 ms
Total hot run time: 185104 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b1c2c317cff3616e2886ee5814303420bdd0d089, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.04
query3	0.25	0.09	0.09
query4	1.61	0.11	0.11
query5	0.28	0.28	0.26
query6	1.15	0.64	0.63
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.59	0.53	0.51
query10	0.57	0.56	0.56
query11	0.17	0.11	0.12
query12	0.15	0.11	0.12
query13	0.64	0.60	0.60
query14	1.00	0.98	1.00
query15	0.81	0.80	0.81
query16	0.41	0.44	0.42
query17	1.09	1.02	1.02
query18	0.23	0.22	0.22
query19	1.88	1.87	1.90
query20	0.02	0.01	0.01
query21	15.44	0.30	0.14
query22	4.67	0.06	0.04
query23	16.02	0.27	0.10
query24	1.34	0.62	1.17
query25	0.12	0.06	0.06
query26	0.15	0.13	0.13
query27	0.09	0.05	0.06
query28	5.31	1.22	1.03
query29	12.55	3.83	3.16
query30	0.28	0.15	0.14
query31	2.82	0.60	0.39
query32	3.23	0.54	0.46
query33	3.04	3.10	3.06
query34	16.60	5.24	4.56
query35	4.56	4.61	4.58
query36	0.65	0.51	0.48
query37	0.10	0.06	0.06
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.15	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.52 s
Total hot run time: 27.81 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (4/4) 🎉
Increment coverage report
Complete coverage report

@yujun777
Copy link
Contributor Author

run buildall

starocean999
starocean999 previously approved these changes Nov 28, 2025
@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33795 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c159b941e14b5aeace8d1749688d9830480dc6f, data reload: false

------ Round 1 ----------------------------------
q1	17706	5044	4921	4921
q2	2993	325	202	202
q3	10295	1297	710	710
q4	10228	873	372	372
q5	7493	2452	2215	2215
q6	182	171	139	139
q7	964	784	643	643
q8	9353	1324	971	971
q9	6883	5378	5242	5242
q10	7108	2246	1771	1771
q11	520	316	290	290
q12	344	372	222	222
q13	17769	3638	3026	3026
q14	228	231	213	213
q15	586	512	514	512
q16	878	868	797	797
q17	595	786	460	460
q18	7639	6909	7022	6909
q19	1206	934	563	563
q20	349	329	231	231
q21	2957	3046	2435	2435
q22	1024	990	951	951
Total cold run time: 107300 ms
Total hot run time: 33795 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4972	4902	4920	4902
q2	340	400	320	320
q3	2125	2660	2284	2284
q4	1314	1742	1297	1297
q5	4190	4430	4557	4430
q6	217	169	128	128
q7	2045	1973	1908	1908
q8	2645	2461	2476	2461
q9	7430	7428	7455	7428
q10	2986	3218	2834	2834
q11	600	527	499	499
q12	670	726	625	625
q13	3479	3946	3344	3344
q14	289	298	284	284
q15	561	505	513	505
q16	892	1091	890	890
q17	1114	1396	1524	1396
q18	8008	7719	7517	7517
q19	853	878	786	786
q20	2023	2103	1907	1907
q21	4769	4241	4127	4127
q22	1046	1039	972	972
Total cold run time: 52568 ms
Total hot run time: 50844 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181736 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c159b941e14b5aeace8d1749688d9830480dc6f, data reload: false

query1	1152	424	386	386
query2	6560	1538	1584	1538
query3	6876	221	224	221
query4	25316	23271	22868	22868
query5	4832	625	454	454
query6	351	240	223	223
query7	4669	507	309	309
query8	302	258	254	254
query9	8720	2617	2640	2617
query10	537	352	304	304
query11	15325	15176	14475	14475
query12	185	128	114	114
query13	1692	575	457	457
query14	9189	5598	5649	5598
query15	218	202	196	196
query16	7388	692	557	557
query17	1191	758	626	626
query18	2007	418	330	330
query19	204	205	176	176
query20	125	127	125	125
query21	279	141	113	113
query22	3959	3979	3877	3877
query23	32871	32139	31983	31983
query24	8489	2436	2365	2365
query25	607	512	451	451
query26	1253	276	164	164
query27	2740	491	350	350
query28	4322	2151	2139	2139
query29	831	630	529	529
query30	339	245	208	208
query31	797	698	632	632
query32	83	77	75	75
query33	600	390	332	332
query34	805	859	551	551
query35	796	826	769	769
query36	892	933	817	817
query37	144	111	82	82
query38	3857	3861	3787	3787
query39	1669	1426	1392	1392
query40	231	133	128	128
query41	65	61	63	61
query42	125	111	111	111
query43	445	452	420	420
query44	1282	776	767	767
query45	214	191	184	184
query46	874	998	655	655
query47	1692	1722	1654	1654
query48	395	422	343	343
query49	799	496	415	415
query50	650	687	410	410
query51	3875	3923	4027	3923
query52	119	112	105	105
query53	244	262	195	195
query54	328	300	269	269
query55	101	94	90	90
query56	350	344	340	340
query57	1142	1147	1080	1080
query58	292	273	277	273
query59	2350	2401	2313	2313
query60	344	351	348	348
query61	166	167	164	164
query62	784	710	693	693
query63	230	196	203	196
query64	4625	1210	935	935
query65	4055	3959	3978	3959
query66	1170	457	354	354
query67	15346	14964	14906	14906
query68	4639	981	648	648
query69	524	362	333	333
query70	1134	1046	1031	1031
query71	421	338	313	313
query72	6098	5052	4969	4969
query73	664	557	343	343
query74	8790	8751	8543	8543
query75	3049	3054	2573	2573
query76	3300	1126	695	695
query77	510	382	317	317
query78	9504	9690	8872	8872
query79	2081	811	606	606
query80	673	577	506	506
query81	502	271	240	240
query82	241	139	108	108
query83	270	267	251	251
query84	263	118	107	107
query85	889	500	461	461
query86	382	307	285	285
query87	4036	4082	4039	4039
query88	3285	2294	2304	2294
query89	379	335	291	291
query90	1831	228	220	220
query91	179	192	140	140
query92	84	68	67	67
query93	2432	988	653	653
query94	719	440	350	350
query95	516	425	407	407
query96	515	558	288	288
query97	2597	2670	2553	2553
query98	240	228	216	216
query99	1314	1409	1282	1282
Total cold run time: 266526 ms
Total hot run time: 181736 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.49 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c159b941e14b5aeace8d1749688d9830480dc6f, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.06	0.05
query3	0.25	0.09	0.09
query4	1.61	0.11	0.11
query5	0.28	0.25	0.24
query6	1.17	0.65	0.64
query7	0.03	0.03	0.03
query8	0.06	0.05	0.04
query9	0.58	0.52	0.50
query10	0.56	0.54	0.56
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.64	0.63	0.60
query14	1.00	0.99	1.00
query15	0.81	0.79	0.80
query16	0.41	0.42	0.42
query17	1.02	1.02	1.00
query18	0.23	0.22	0.21
query19	1.91	1.82	1.82
query20	0.02	0.01	0.01
query21	15.47	0.28	0.14
query22	4.88	0.05	0.05
query23	16.02	0.26	0.10
query24	1.51	0.34	0.39
query25	0.08	0.09	0.05
query26	0.14	0.14	0.13
query27	0.09	0.05	0.04
query28	4.50	1.23	1.02
query29	12.62	3.97	3.22
query30	0.28	0.14	0.13
query31	2.82	0.60	0.40
query32	3.24	0.54	0.45
query33	3.16	3.06	3.17
query34	17.00	5.22	4.55
query35	4.60	4.57	4.60
query36	0.67	0.54	0.55
query37	0.10	0.06	0.06
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.13	0.13
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.03	0.04
Total cold run time: 98.71 s
Total hot run time: 27.49 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 35ce75a into apache:master Nov 28, 2025
28 of 30 checks passed
yujun777 added a commit to yujun777/doris that referenced this pull request Nov 28, 2025
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Dec 1, 2025
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Dec 2, 2025
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Dec 8, 2025
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Jan 9, 2026
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Jan 9, 2026
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Jan 12, 2026
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
yujun777 added a commit to yujun777/doris that referenced this pull request Jan 21, 2026
…on (apache#58475)

Fix immutable map removeIf throw UnsupportedOperationException 

introduce by apache#57537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants