Skip to content

[fix](nereids) fix add min max rule throw UnsupportedOperationException #58475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 2 commits into from
Nov 28, 2025
Merged

[fix](nereids) fix add min max rule throw UnsupportedOperationException #58475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c2c31
fix add min max rule throw UnsupportedOperationException
yujun777 Nov 27, 2025
1c159b9
add test
yujun777 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@

import com.google.common.collect.BoundType;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.common.collect.Range;
Expand Down Expand Up @@ -311,17 +310,17 @@ public Map<Expression, MinMaxValue> visitDiscreteValue(DiscreteValue value, Void

@Override
public Map<Expression, MinMaxValue> visitNotDiscreteValue(NotDiscreteValue value, Void context) {
return ImmutableMap.of();
return Maps.newHashMap();
}

@Override
public Map<Expression, MinMaxValue> visitIsNullValue(IsNullValue value, Void context) {
return ImmutableMap.of();
return Maps.newHashMap();
}

@Override
public Map<Expression, MinMaxValue> visitIsNotNullValue(IsNotNullValue value, Void context) {
return ImmutableMap.of();
return Maps.newHashMap();
}

@Override
Expand Down Expand Up @@ -412,6 +411,6 @@ public Map<Expression, MinMaxValue> visitCompoundValue(CompoundValue valueDesc,

@Override
public Map<Expression, MinMaxValue> visitUnknownValue(UnknownValue valueDesc, Void context) {
return ImmutableMap.of();
return Maps.newHashMap();
}
}
1 change: 1 addition & 0 deletions ...e-core/src/test/java/org/apache/doris/nereids/rules/expression/ExpressionRewriteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ void testAddMinMax() {
)
));

assertRewriteAfterTypeCoercion("5 * 100 >= 10 and 5 * 100 <= 5", "5 * 100 >= 10 and 5 * 100 <= 5");
assertRewriteAfterTypeCoercion("TA >= 10", "TA >= 10");
assertRewriteAfterTypeCoercion("TA between 10 and 20", "TA >= 10 and TA <= 20");
assertRewriteAfterTypeCoercion("TA between 10 and 20 or TA >= 30",
Expand Down
Loading