Skip to content

[fix](olap) Fix the crash in column pruning caused by the light schema change #58614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrhhsg merged 1 commit into from
Dec 3, 2025
Merged

[fix](olap) Fix the crash in column pruning caused by the light schema change #58614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions be/src/olap/rowset/segment_v2/column_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <assert.h>
#include <gen_cpp/Descriptors_types.h>
#include <gen_cpp/segment_v2.pb.h>
#include <glog/logging.h>

#include <algorithm>
#include <memory>
Expand Down Expand Up @@ -888,6 +889,7 @@ Status ColumnReader::new_struct_iterator(ColumnIteratorUPtr* iterator,
TabletColumn column = tablet_column->get_sub_column(i);
ColumnIteratorUPtr it;
RETURN_IF_ERROR(Segment::new_default_iterator(column, &it));
it->set_column_name(column.name());
sub_column_iterators.emplace_back(std::move(it));
}

Expand Down
4 changes: 4 additions & 0 deletions regression-test/data/datatype_p0/complex_types/test_pruned_columns.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@
0.41
0.99

-- !sql8 --
\N
added_z

33 changes: 33 additions & 0 deletions regression-test/suites/datatype_p0/complex_types/test_pruned_columns.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,37 @@ suite("test_pruned_columns") {
qt_sql7 """
select struct_element(dynamic_attributes['theme_preference'], 'confidence_score') from `tbl_test_pruned_columns_map` order by id;
"""

// test light schema change with nested complex types
sql """
DROP TABLE IF EXISTS nested_sc_tbl;
CREATE TABLE nested_sc_tbl (
`id` BIGINT,
`s_info` STRUCT<a:INT, b:VARCHAR(20)>,
`arr_s` ARRAY<STRUCT<x:INT, y:INT>>,
`map_s` MAP<VARCHAR, STRUCT<m:INT, n:FLOAT>>
)
UNIQUE KEY(`id`)
DISTRIBUTED BY HASH(`id`) BUCKETS 4
PROPERTIES (
"replication_num" = "1",
"light_schema_change" = "true"
);
"""
sql """
ALTER TABLE nested_sc_tbl MODIFY COLUMN s_info STRUCT<a:INT, b:VARCHAR(25), c:INT>;
"""
sql """
INSERT INTO nested_sc_tbl VALUES (1, struct(10, 'v1_struct', 100), array(struct(100, 200)), map('k1', struct(1, 1.1)));
"""
sql """
ALTER TABLE nested_sc_tbl MODIFY COLUMN arr_s ARRAY<STRUCT<x:INT, y:INT, z:VARCHAR(10)>>;
"""
sql """
INSERT INTO nested_sc_tbl VALUES (3, struct(30.5, 'v3', 888), array(struct(500, 600, 'added_z'), struct(501, 601, 'added_z_2')), map('k3', struct(3, 3.3)));
"""

qt_sql8 """
select struct_element(element_at(arr_s, 1), 'z') as inner_z FROM nested_sc_tbl ORDER BY id;
"""
}
Loading