Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Dec 2, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Should set the column name of sub-iterator of StructIterator.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 2, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34377 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e60ecf91d18fc3a818547dc7441607e1f52c69f4, data reload: false

------ Round 1 ----------------------------------
q1	17596	5105	4930	4930
q2	2039	306	204	204
q3	10256	1298	721	721
q4	10210	813	317	317
q5	7530	2461	2059	2059
q6	193	174	138	138
q7	960	793	639	639
q8	9349	1347	1134	1134
q9	7016	5337	5353	5337
q10	7140	2208	1819	1819
q11	569	334	305	305
q12	358	386	240	240
q13	17796	3729	2986	2986
q14	251	232	227	227
q15	593	521	521	521
q16	903	870	806	806
q17	680	775	558	558
q18	7557	7135	7115	7115
q19	1097	976	608	608
q20	381	362	235	235
q21	4024	3484	2546	2546
q22	1034	1014	932	932
Total cold run time: 107532 ms
Total hot run time: 34377 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5117	4987	4965	4965
q2	336	403	325	325
q3	2155	2618	2291	2291
q4	1325	1738	1291	1291
q5	4215	4523	4514	4514
q6	233	174	135	135
q7	2057	2027	1806	1806
q8	2809	2545	2490	2490
q9	7592	7503	7636	7503
q10	3081	3236	2802	2802
q11	612	528	492	492
q12	791	807	586	586
q13	3471	3845	3273	3273
q14	295	292	301	292
q15	566	519	516	516
q16	894	928	888	888
q17	1215	1354	1383	1354
q18	8011	7647	7585	7585
q19	964	894	902	894
q20	2015	2005	1846	1846
q21	4608	4218	4129	4129
q22	1110	1047	984	984
Total cold run time: 53472 ms
Total hot run time: 50961 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182169 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e60ecf91d18fc3a818547dc7441607e1f52c69f4, data reload: false

query1	1086	413	387	387
query2	6581	1226	1168	1168
query3	6764	228	221	221
query4	25286	23308	23058	23058
query5	4956	668	503	503
query6	342	244	231	231
query7	4653	529	307	307
query8	317	254	252	252
query9	8748	2634	2665	2634
query10	541	355	310	310
query11	15276	15065	14604	14604
query12	188	123	111	111
query13	1680	581	450	450
query14	9574	6082	5901	5901
query15	210	197	187	187
query16	7491	686	525	525
query17	1199	773	605	605
query18	2043	428	336	336
query19	206	202	180	180
query20	134	126	122	122
query21	223	133	113	113
query22	3869	4051	3934	3934
query23	32805	32040	32032	32032
query24	8576	2450	2420	2420
query25	665	559	515	515
query26	1254	286	177	177
query27	2745	523	355	355
query28	4389	2170	2162	2162
query29	859	660	527	527
query30	321	244	214	214
query31	828	709	613	613
query32	89	79	77	77
query33	624	403	354	354
query34	892	882	551	551
query35	803	829	769	769
query36	906	957	848	848
query37	133	111	91	91
query38	3892	3863	3841	3841
query39	1481	1434	1426	1426
query40	254	140	123	123
query41	72	69	69	69
query42	126	114	120	114
query43	458	462	416	416
query44	1338	760	760	760
query45	203	200	182	182
query46	898	1029	661	661
query47	1695	1721	1642	1642
query48	416	433	329	329
query49	800	532	429	429
query50	697	704	410	410
query51	3826	3825	3991	3825
query52	118	114	116	114
query53	260	263	195	195
query54	345	325	296	296
query55	96	99	101	99
query56	352	348	351	348
query57	1145	1196	1098	1098
query58	308	282	287	282
query59	2327	2472	2330	2330
query60	370	380	361	361
query61	236	160	162	160
query62	791	707	656	656
query63	233	195	197	195
query64	4522	1203	927	927
query65	4053	3967	4019	3967
query66	1151	428	335	335
query67	15268	14958	14817	14817
query68	8396	1016	626	626
query69	512	346	308	308
query70	1126	1040	956	956
query71	477	344	318	318
query72	5821	4889	4886	4886
query73	705	580	351	351
query74	8887	8833	8617	8617
query75	3711	3026	2615	2615
query76	3818	1160	761	761
query77	825	408	317	317
query78	9443	9562	8825	8825
query79	2085	905	571	571
query80	669	581	494	494
query81	485	268	236	236
query82	479	159	130	130
query83	273	264	252	252
query84	261	114	100	100
query85	966	491	447	447
query86	349	278	310	278
query87	4175	4020	4045	4020
query88	3887	2281	2321	2281
query89	400	328	306	306
query90	2005	214	213	213
query91	177	164	148	148
query92	90	71	70	70
query93	1373	1043	656	656
query94	728	463	347	347
query95	510	405	410	405
query96	536	564	285	285
query97	2694	2725	2619	2619
query98	250	228	210	210
query99	1388	1423	1270	1270
Total cold run time: 272488 ms
Total hot run time: 182169 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e60ecf91d18fc3a818547dc7441607e1f52c69f4, data reload: false

query1	0.05	0.06	0.05
query2	0.10	0.06	0.05
query3	0.25	0.10	0.08
query4	1.61	0.11	0.11
query5	0.28	0.25	0.24
query6	1.15	0.65	0.64
query7	0.03	0.03	0.03
query8	0.06	0.04	0.05
query9	0.56	0.51	0.50
query10	0.54	0.56	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.62	0.60
query14	0.98	0.98	0.98
query15	0.81	0.80	0.79
query16	0.40	0.40	0.39
query17	1.08	1.06	1.05
query18	0.23	0.24	0.21
query19	1.84	1.82	1.82
query20	0.02	0.02	0.02
query21	15.44	0.28	0.14
query22	4.65	0.06	0.05
query23	15.94	0.29	0.10
query24	1.71	0.33	0.22
query25	0.06	0.06	0.08
query26	0.13	0.14	0.13
query27	0.05	0.05	0.06
query28	3.13	1.23	1.03
query29	12.57	4.10	3.21
query30	0.28	0.14	0.12
query31	2.83	0.63	0.39
query32	3.24	0.57	0.46
query33	3.02	3.06	3.00
query34	16.91	5.23	4.54
query35	4.58	4.49	4.53
query36	0.65	0.51	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.02
query43	0.05	0.03	0.04
Total cold run time: 96.66 s
Total hot run time: 27.21 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.52% (18734/35007)
Line Coverage 39.10% (172704/441652)
Region Coverage 33.67% (133556/396649)
Branch Coverage 34.65% (57547/166060)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.22% (24789/34323)
Line Coverage 58.86% (259715/441257)
Region Coverage 53.80% (215980/401459)
Branch Coverage 55.23% (92209/166957)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

PR approved by anyone and no changes requested.

@mrhhsg mrhhsg merged commit 8b37ab6 into apache:master Dec 3, 2025
27 of 29 checks passed
@mrhhsg mrhhsg deleted the fix_lsc branch December 3, 2025 09:04
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
…a change (apache#58614)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Should set the column name of sub-iterator of StructIterator.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
mrhhsg added a commit that referenced this pull request Dec 23, 2025
…a change (#58614)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Should set the column name of sub-iterator of StructIterator.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Dec 24, 2025
…rning (#59286)

### What problem does this PR solve?

Problem Summary:

### Release note

Cherry-pick #58370 #58354 #59043 #58851 #58485 #58682 #58614 #58373
#57204 #58719 #58471 #58573 #58657

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
Co-authored-by: Jerry Hu <mrhhsg@gmail.com>
Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
Co-authored-by: lihangyu <lihangyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants