Skip to content

[fix](nereids) fix Input slot(s) not in child's output #58471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
924060929 merged 2 commits into from
Dec 1, 2025
Merged

[fix](nereids) fix Input slot(s) not in child's output #58471

924060929 merged 2 commits into from
Dec 1, 2025

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Nov 27, 2025

What problem does this PR solve?

fix Input slot(s) not in child's output, introduced by #57204

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

924060929 commented Nov 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

TPC-H: Total hot run time: 34197 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a4530b75bce3ea586f37084be1a803d083d37a2b, data reload: false

------ Round 1 ----------------------------------
q1	17597	5076	4940	4940
q2	2027	318	221	221
q3	10245	1331	756	756
q4	10243	939	385	385
q5	7768	2449	2287	2287
q6	188	171	135	135
q7	933	799	651	651
q8	9363	1391	1076	1076
q9	6890	5216	5299	5216
q10	6858	2230	1822	1822
q11	518	310	297	297
q12	336	371	227	227
q13	17820	3625	3025	3025
q14	240	248	220	220
q15	590	532	528	528
q16	1040	1014	945	945
q17	582	746	497	497
q18	7813	6903	7060	6903
q19	1089	948	571	571
q20	354	334	232	232
q21	3567	3226	2319	2319
q22	1042	989	944	944
Total cold run time: 107103 ms
Total hot run time: 34197 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4970	4946	4918	4918
q2	340	400	309	309
q3	2125	2665	2263	2263
q4	1317	1761	1261	1261
q5	4218	4385	4477	4385
q6	220	178	137	137
q7	2048	2063	1792	1792
q8	2576	2539	2448	2448
q9	7429	7346	7523	7346
q10	3067	3279	2856	2856
q11	589	509	487	487
q12	709	760	648	648
q13	3681	3838	3352	3352
q14	288	299	274	274
q15	553	520	507	507
q16	1105	1124	1103	1103
q17	1137	1460	1365	1365
q18	7996	7639	7428	7428
q19	825	772	787	772
q20	2023	2016	1799	1799
q21	4663	4261	4136	4136
q22	1034	1022	967	967
Total cold run time: 52913 ms
Total hot run time: 50553 ms

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

TPC-DS: Total hot run time: 182339 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a4530b75bce3ea586f37084be1a803d083d37a2b, data reload: false

query1	1060	416	393	393
query2	6557	1565	1584	1565
query3	6762	228	222	222
query4	25299	23179	22842	22842
query5	4814	647	474	474
query6	352	246	238	238
query7	4666	494	306	306
query8	310	270	279	270
query9	8758	2595	2601	2595
query10	533	348	298	298
query11	15350	15190	14885	14885
query12	178	122	113	113
query13	1739	564	453	453
query14	11014	8831	8805	8805
query15	213	201	182	182
query16	7601	710	535	535
query17	1210	773	649	649
query18	2030	437	356	356
query19	225	206	182	182
query20	128	129	125	125
query21	220	138	117	117
query22	4128	4153	4124	4124
query23	32670	31757	31788	31757
query24	8509	2442	2396	2396
query25	626	558	489	489
query26	1258	285	167	167
query27	2736	496	357	357
query28	4340	2141	2134	2134
query29	844	652	532	532
query30	307	239	215	215
query31	863	737	609	609
query32	86	77	77	77
query33	610	397	357	357
query34	808	919	534	534
query35	807	837	741	741
query36	872	907	830	830
query37	131	110	90	90
query38	3394	3339	3274	3274
query39	1478	1418	1403	1403
query40	229	127	121	121
query41	67	65	60	60
query42	122	108	109	108
query43	436	452	412	412
query44	1272	752	745	745
query45	199	194	182	182
query46	866	995	662	662
query47	1694	1721	1657	1657
query48	406	423	329	329
query49	790	501	421	421
query50	650	668	420	420
query51	3865	3971	3840	3840
query52	109	109	106	106
query53	236	261	197	197
query54	299	290	289	289
query55	98	94	89	89
query56	380	333	316	316
query57	1131	1161	1102	1102
query58	285	267	268	267
query59	2307	2365	2338	2338
query60	355	342	334	334
query61	161	161	160	160
query62	786	710	652	652
query63	226	196	193	193
query64	4573	1202	903	903
query65	4078	3962	3981	3962
query66	1129	433	334	334
query67	15338	15074	14773	14773
query68	8331	960	626	626
query69	515	339	304	304
query70	1223	1210	1219	1210
query71	478	330	315	315
query72	5800	2616	5509	2616
query73	816	753	353	353
query74	8715	8991	8574	8574
query75	3984	3307	2819	2819
query76	3787	1115	713	713
query77	821	403	309	309
query78	9379	9475	8912	8912
query79	2370	825	591	591
query80	699	575	486	486
query81	486	269	231	231
query82	430	166	134	134
query83	299	255	249	249
query84	314	120	96	96
query85	925	493	441	441
query86	337	287	305	287
query87	3515	3535	3424	3424
query88	3731	2243	2279	2243
query89	391	337	293	293
query90	1977	218	214	214
query91	171	169	143	143
query92	88	69	67	67
query93	1581	990	653	653
query94	721	460	327	327
query95	503	414	403	403
query96	504	549	286	286
query97	2957	2983	2907	2907
query98	243	229	206	206
query99	1431	1384	1244	1244
Total cold run time: 273095 ms
Total hot run time: 182339 ms

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

ClickBench: Total hot run time: 27.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a4530b75bce3ea586f37084be1a803d083d37a2b, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.05
query3	0.26	0.09	0.09
query4	1.61	0.11	0.12
query5	0.28	0.25	0.28
query6	1.17	0.63	0.64
query7	0.04	0.03	0.02
query8	0.06	0.04	0.05
query9	0.59	0.51	0.50
query10	0.56	0.56	0.55
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.63	0.61	0.61
query14	1.00	0.98	0.98
query15	0.82	0.79	0.79
query16	0.41	0.39	0.39
query17	1.01	1.00	1.04
query18	0.23	0.21	0.21
query19	1.94	1.79	1.79
query20	0.02	0.01	0.01
query21	15.45	0.29	0.14
query22	4.75	0.05	0.05
query23	16.21	0.25	0.10
query24	1.89	0.30	0.59
query25	0.06	0.05	0.06
query26	0.15	0.14	0.13
query27	0.07	0.07	0.04
query28	3.86	1.22	1.03
query29	12.62	3.90	3.18
query30	0.28	0.14	0.11
query31	2.81	0.60	0.40
query32	3.22	0.54	0.47
query33	3.02	3.16	3.06
query34	16.56	5.16	4.50
query35	4.56	4.64	4.59
query36	0.65	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.05	0.04
query39	0.04	0.04	0.03
query40	0.16	0.16	0.14
query41	0.08	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 97.8 s
Total hot run time: 27.3 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 27, 2025

FE Regression Coverage Report

Increment line coverage 90.00% (9/10) 🎉
Increment coverage report
Complete coverage report

@924060929
Copy link
Contributor Author

924060929 commented Nov 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

TPC-H: Total hot run time: 34056 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec03ca8a58b581552e8ba6a758723abb562f2b12, data reload: false

------ Round 1 ----------------------------------
q1	17613	5020	5051	5020
q2	2043	311	221	221
q3	10287	1347	707	707
q4	10224	832	351	351
q5	7542	2527	2187	2187
q6	185	168	137	137
q7	969	785	625	625
q8	9349	1303	990	990
q9	7053	5391	5346	5346
q10	6849	2222	1799	1799
q11	518	294	286	286
q12	343	375	218	218
q13	17788	3679	3014	3014
q14	230	225	210	210
q15	598	522	517	517
q16	866	854	800	800
q17	622	763	517	517
q18	7493	7039	6992	6992
q19	1092	943	569	569
q20	329	355	230	230
q21	3533	3361	2378	2378
q22	1044	1003	942	942
Total cold run time: 106570 ms
Total hot run time: 34056 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4935	4916	4905	4905
q2	324	400	310	310
q3	2106	2654	2299	2299
q4	1340	1764	1293	1293
q5	4195	4289	4558	4289
q6	217	174	129	129
q7	2052	2057	1817	1817
q8	2632	2457	2479	2457
q9	7480	7434	7462	7434
q10	3140	3292	2860	2860
q11	593	528	491	491
q12	722	733	653	653
q13	3455	3879	3361	3361
q14	300	333	296	296
q15	565	505	509	505
q16	889	932	883	883
q17	1147	1406	1431	1406
q18	7923	7850	7517	7517
q19	780	793	777	777
q20	1974	1989	1824	1824
q21	4653	4276	4196	4196
q22	1081	1042	957	957
Total cold run time: 52503 ms
Total hot run time: 50659 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 28, 2025

FE UT Coverage Report

Increment line coverage 100.00% (11/11) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

TPC-DS: Total hot run time: 182025 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec03ca8a58b581552e8ba6a758723abb562f2b12, data reload: false

query1	1049	443	414	414
query2	6589	1196	1184	1184
query3	6757	225	230	225
query4	25600	23472	22907	22907
query5	4961	670	505	505
query6	349	262	236	236
query7	4642	498	315	315
query8	314	249	249	249
query9	8738	2586	2590	2586
query10	556	355	331	331
query11	15487	15085	14874	14874
query12	195	124	114	114
query13	1709	586	456	456
query14	9588	5981	6042	5981
query15	219	208	186	186
query16	7559	719	536	536
query17	1207	780	667	667
query18	2055	438	349	349
query19	221	218	184	184
query20	133	125	122	122
query21	223	136	121	121
query22	3828	3916	3819	3819
query23	32894	31949	31974	31949
query24	8498	2381	2416	2381
query25	641	560	494	494
query26	1241	282	176	176
query27	2728	511	351	351
query28	4324	2145	2103	2103
query29	829	655	526	526
query30	311	245	218	218
query31	814	706	635	635
query32	87	78	75	75
query33	635	390	348	348
query34	820	872	592	592
query35	795	837	744	744
query36	899	915	844	844
query37	117	109	85	85
query38	3872	3821	3828	3821
query39	1461	1416	1401	1401
query40	225	128	123	123
query41	65	61	61	61
query42	124	111	109	109
query43	421	450	405	405
query44	1303	762	751	751
query45	199	189	190	189
query46	876	987	654	654
query47	1665	1738	1678	1678
query48	393	423	326	326
query49	776	528	414	414
query50	660	708	420	420
query51	3844	4003	3856	3856
query52	107	112	101	101
query53	249	265	201	201
query54	325	335	292	292
query55	93	96	96	96
query56	329	333	319	319
query57	1170	1176	1099	1099
query58	298	268	270	268
query59	2323	2424	2303	2303
query60	356	369	341	341
query61	168	167	164	164
query62	790	728	654	654
query63	230	190	191	190
query64	4455	1196	940	940
query65	4015	3957	3969	3957
query66	1141	441	331	331
query67	15148	15129	14957	14957
query68	8356	955	629	629
query69	511	344	306	306
query70	1097	1004	965	965
query71	475	329	321	321
query72	5952	4843	4878	4843
query73	689	570	344	344
query74	8773	8748	8576	8576
query75	3653	3000	2558	2558
query76	3813	1122	714	714
query77	832	407	316	316
query78	9428	9695	8907	8907
query79	2041	843	593	593
query80	667	591	503	503
query81	493	275	238	238
query82	454	144	115	115
query83	268	267	252	252
query84	262	123	102	102
query85	937	484	446	446
query86	341	308	281	281
query87	4068	4075	3929	3929
query88	3819	2317	2272	2272
query89	396	334	305	305
query90	1999	222	225	222
query91	184	176	142	142
query92	87	71	71	71
query93	1297	990	660	660
query94	737	440	349	349
query95	506	414	410	410
query96	513	550	282	282
query97	2614	2674	2597	2597
query98	249	226	212	212
query99	1323	1380	1262	1262
Total cold run time: 271527 ms
Total hot run time: 182025 ms

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

ClickBench: Total hot run time: 27.57 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec03ca8a58b581552e8ba6a758723abb562f2b12, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.04
query3	0.26	0.09	0.09
query4	1.62	0.11	0.11
query5	0.29	0.27	0.27
query6	1.18	0.64	0.62
query7	0.03	0.03	0.03
query8	0.06	0.04	0.05
query9	0.58	0.51	0.51
query10	0.54	0.56	0.55
query11	0.16	0.11	0.12
query12	0.14	0.12	0.11
query13	0.62	0.60	0.59
query14	1.00	0.97	0.99
query15	0.82	0.80	0.80
query16	0.40	0.42	0.41
query17	0.99	1.07	1.07
query18	0.23	0.21	0.22
query19	1.94	1.83	1.79
query20	0.02	0.01	0.02
query21	15.44	0.27	0.14
query22	4.67	0.05	0.04
query23	15.93	0.27	0.10
query24	1.33	0.58	0.42
query25	0.10	0.05	0.06
query26	0.15	0.13	0.13
query27	0.08	0.07	0.06
query28	4.97	1.21	1.03
query29	12.65	3.88	3.23
query30	0.27	0.15	0.12
query31	2.81	0.61	0.40
query32	3.23	0.53	0.46
query33	3.10	3.10	3.10
query34	16.74	5.15	4.50
query35	4.48	4.58	4.55
query36	0.68	0.50	0.49
query37	0.11	0.07	0.07
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.04
Total cold run time: 98.23 s
Total hot run time: 27.57 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 28, 2025

FE Regression Coverage Report

Increment line coverage 90.91% (10/11) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit b788842 into apache:master Dec 1, 2025
27 of 28 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@924060929 @nagisa-kunhah
[fix](nereids) fix Input slot(s) not in child's output (apache#58471)
bfa3902 
fix `Input slot(s) not in child's output`, introduced by apache#57204
924060929 added a commit that referenced this pull request Dec 23, 2025
@924060929
[fix](nereids) fix Input slot(s) not in child's output (#58471)
adcdfd4 
fix `Input slot(s) not in child's output`, introduced by #57204

(cherry picked from commit b788842)
@kaka11chen kaka11chen mentioned this pull request Dec 23, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Dec 24, 2025
@kaka11chen @924060929
@mrhhsg @eldenmoon
[feature](reader) Optimize Complex Type Column Reading with Column Pu…
eea2586 
…rning (#59286)

### What problem does this PR solve?

Problem Summary:

### Release note

Cherry-pick #58370 #58354 #59043 #58851 #58485 #58682 #58614 #58373
#57204 #58719 #58471 #58573 #58657

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
Co-authored-by: Jerry Hu <mrhhsg@gmail.com>
Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
Co-authored-by: lihangyu <lihangyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@924060929 @hello-stephen @doris-robot @englefly @morrySnow @yiguolei