Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Dec 3, 2025

What problem does this PR solve?

The next_batch method should accumulate the row count.

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 3, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34292 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9fc119ef6c5f76523f8e6be730543d62c21f9594, data reload: false

------ Round 1 ----------------------------------
q1	17731	5061	4873	4873
q2	2079	322	212	212
q3	10234	1321	727	727
q4	10204	833	327	327
q5	7606	2417	2181	2181
q6	192	168	137	137
q7	967	861	641	641
q8	9384	1352	1128	1128
q9	7043	5372	5337	5337
q10	6845	2203	1780	1780
q11	548	314	307	307
q12	361	375	226	226
q13	17771	3732	3016	3016
q14	237	244	219	219
q15	599	527	514	514
q16	899	857	784	784
q17	719	780	542	542
q18	7490	7268	7001	7001
q19	1107	955	611	611
q20	377	371	241	241
q21	3995	3455	2533	2533
q22	1080	997	955	955
Total cold run time: 107468 ms
Total hot run time: 34292 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5063	4999	4966	4966
q2	325	423	319	319
q3	2153	2656	2314	2314
q4	1342	1760	1330	1330
q5	4285	4554	4482	4482
q6	228	178	128	128
q7	2090	1980	1935	1935
q8	2772	2578	2527	2527
q9	7539	7543	7493	7493
q10	3068	3234	2854	2854
q11	610	534	511	511
q12	695	759	609	609
q13	3484	3956	3353	3353
q14	290	314	305	305
q15	549	503	508	503
q16	900	928	878	878
q17	1172	1442	1431	1431
q18	8071	7768	7430	7430
q19	925	890	902	890
q20	1997	2030	1795	1795
q21	4681	4288	4179	4179
q22	1104	1063	986	986
Total cold run time: 53343 ms
Total hot run time: 51218 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182774 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9fc119ef6c5f76523f8e6be730543d62c21f9594, data reload: false

query1	1060	408	394	394
query2	6589	1165	1193	1165
query3	6744	242	231	231
query4	25484	23456	22858	22858
query5	4834	669	493	493
query6	353	266	250	250
query7	4673	525	308	308
query8	309	253	246	246
query9	8729	2685	2726	2685
query10	564	407	331	331
query11	15233	14835	15173	14835
query12	188	119	121	119
query13	1694	604	461	461
query14	9592	6023	6037	6023
query15	220	203	189	189
query16	7548	728	540	540
query17	1225	786	640	640
query18	2039	451	349	349
query19	222	213	210	210
query20	133	133	123	123
query21	222	139	117	117
query22	3823	4052	3936	3936
query23	32718	32000	31858	31858
query24	8582	2474	2432	2432
query25	638	562	500	500
query26	1241	285	178	178
query27	2713	519	350	350
query28	4349	2218	2191	2191
query29	850	667	536	536
query30	325	255	219	219
query31	875	711	633	633
query32	88	78	84	78
query33	633	398	350	350
query34	856	933	562	562
query35	820	855	737	737
query36	909	963	866	866
query37	130	114	91	91
query38	3909	3908	3882	3882
query39	1480	1415	1397	1397
query40	228	130	123	123
query41	64	61	65	61
query42	130	119	124	119
query43	460	451	417	417
query44	1361	758	766	758
query45	200	199	184	184
query46	920	1076	661	661
query47	1678	1751	1637	1637
query48	399	439	339	339
query49	754	501	433	433
query50	708	720	414	414
query51	3860	3921	3986	3921
query52	126	120	106	106
query53	260	267	195	195
query54	301	296	286	286
query55	97	100	92	92
query56	349	337	335	335
query57	1122	1169	1086	1086
query58	299	277	317	277
query59	2293	2414	2297	2297
query60	354	356	347	347
query61	168	162	163	162
query62	778	716	656	656
query63	235	200	205	200
query64	4486	1231	915	915
query65	4094	3979	3971	3971
query66	1134	443	336	336
query67	15425	15023	14831	14831
query68	8292	1016	656	656
query69	504	353	320	320
query70	1088	1055	1021	1021
query71	481	337	312	312
query72	5807	4885	4829	4829
query73	727	602	348	348
query74	8579	8804	8709	8709
query75	3572	3053	2565	2565
query76	3744	1167	757	757
query77	800	410	336	336
query78	9489	9664	8902	8902
query79	1971	941	587	587
query80	694	595	500	500
query81	509	273	242	242
query82	432	143	114	114
query83	277	264	256	256
query84	258	126	100	100
query85	921	494	470	470
query86	336	307	279	279
query87	4077	4079	4079	4079
query88	3357	2307	2294	2294
query89	393	341	298	298
query90	1948	234	217	217
query91	177	182	147	147
query92	85	73	68	68
query93	1209	1065	706	706
query94	726	474	341	341
query95	520	433	431	431
query96	563	559	292	292
query97	2626	2689	2584	2584
query98	240	214	217	214
query99	1512	1418	1278	1278
Total cold run time: 270791 ms
Total hot run time: 182774 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9fc119ef6c5f76523f8e6be730543d62c21f9594, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.10	0.11
query5	0.27	0.26	0.26
query6	1.18	0.65	0.63
query7	0.03	0.02	0.02
query8	0.05	0.04	0.05
query9	0.57	0.51	0.51
query10	0.58	0.56	0.56
query11	0.16	0.11	0.11
query12	0.14	0.11	0.13
query13	0.63	0.61	0.61
query14	1.02	1.00	0.98
query15	0.81	0.80	0.80
query16	0.42	0.39	0.40
query17	1.00	1.01	1.03
query18	0.24	0.22	0.21
query19	1.93	1.90	1.76
query20	0.02	0.01	0.02
query21	15.44	0.29	0.14
query22	4.76	0.05	0.05
query23	15.92	0.29	0.10
query24	2.11	1.19	0.27
query25	0.08	0.07	0.07
query26	0.15	0.14	0.14
query27	0.07	0.05	0.06
query28	4.66	1.33	1.04
query29	12.61	3.98	3.24
query30	0.29	0.15	0.11
query31	2.81	0.62	0.40
query32	3.24	0.57	0.47
query33	3.04	3.12	3.10
query34	16.83	5.16	4.54
query35	4.57	4.55	4.56
query36	0.67	0.50	0.50
query37	0.13	0.06	0.07
query38	0.07	0.04	0.04
query39	0.05	0.03	0.04
query40	0.18	0.15	0.14
query41	0.09	0.03	0.02
query42	0.05	0.04	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.94 s
Total hot run time: 27.42 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.36% (18639/34930)
Line Coverage 39.02% (172086/441042)
Region Coverage 33.63% (133207/396152)
Branch Coverage 34.59% (57338/165761)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.16% (24713/34247)
Line Coverage 58.86% (259366/440650)
Region Coverage 53.83% (215841/400963)
Branch Coverage 55.28% (92126/166658)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by anyone and no changes requested.

@mrhhsg mrhhsg merged commit 1305f11 into apache:master Dec 4, 2025
27 of 29 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
…ns (apache#58682)

### What problem does this PR solve?

The `next_batch` method should accumulate the row count.

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
mrhhsg added a commit that referenced this pull request Dec 23, 2025
…ns (#58682)

### What problem does this PR solve?

The `next_batch` method should accumulate the row count.

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Dec 24, 2025
…rning (#59286)

### What problem does this PR solve?

Problem Summary:

### Release note

Cherry-pick #58370 #58354 #59043 #58851 #58485 #58682 #58614 #58373
#57204 #58719 #58471 #58573 #58657

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
Co-authored-by: Jerry Hu <mrhhsg@gmail.com>
Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
Co-authored-by: lihangyu <lihangyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants