Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade skeches-core to version 0.8.3 #3710

Closed
wants to merge 1 commit into from

Conversation

himanshug
Copy link
Contributor

No description provided.

@gianm
Copy link
Contributor

gianm commented Nov 23, 2016

  • jdk8 test failure looks transient (AnnouncerTest)
  • jdk7 test failure looks legit, sketches-core is no longer built for jdk7: java.lang.UnsupportedClassVersionError: com/yahoo/memory/Memory : Unsupported major.minor version 52.0

@drcrallen
Copy link
Contributor

Can probably add data-sketches to the build method used for the caffeine cache extension.

@drcrallen
Copy link
Contributor

buuut, would be worth calling out in the java8 thread in the dev list

@himanshug
Copy link
Contributor Author

@gianm @drcrallen I forgot the java8 catch, I guess ...for now I would let datasketches work with java-7 and not upgrade sketches-core unless necessary.

@himanshug himanshug closed this Nov 23, 2016
@gianm
Copy link
Contributor

gianm commented Nov 23, 2016

Datasketches previously supported jdk7 so imo it should continue to do so until Druid itself moves on.

@gianm gianm mentioned this pull request Dec 6, 2016
@himanshug himanshug deleted the sketch_version_update branch January 3, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants