Require Java 8 and include some Java 8 dependencies. #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade Jetty to 9.3.16.v20170120. - Upgrade DataSketches to 0.8.4. - Bundle caffeine-cache by default. - Still target Java 7 when compiling base Druid classes.
|
Shall we also disable travis builds for jdk7? They, of course, do not pass after applying this patch. |
|
I tested this PR for hadoop compatibility with:
all running Java 8 on the hadoop cluster side, running a batch ingestion task on the wikiticker data, those all passed |
|
Thanks @jon-wei! In that case I'll take off the WIP tag and this is ready for review. |
gianm
changed the title
drcrallen
requested changes
Feb 14, 2017
| @@ -38,7 +38,7 @@ | |||
| <dependency> | |||
| <groupId>com.yahoo.datasketches</groupId> | |||
| <artifactId>sketches-core</artifactId> | |||
| <version>0.4.1</version> | |||
| <version>0.8.4</version> | |||
There was a problem hiding this comment.
Is this really germane to java 8?
drcrallen
approved these changes
Feb 14, 2017
|
Discussed in dev sync. @gianm was going to update travis yaml before merge |
|
Removed jdk7 from travis.yml. |
|
👍 |
This was referenced Feb 14, 2017
Closed
This was referenced Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #3746, #3745, #3710, #3595.
Our hadoop gauntlet tests don't pass with this, because they are running on Java 7. But hopefully they will pass after upgrading that test environment to Java 8. In the meantime I'm doing this as a WIP PR just so people can see the changes and try it in their own environment if they want.