Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: generic #945

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Fix: generic #945

merged 2 commits into from
Dec 20, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

fix generic "encode hessian.Object"

@codecov-io
Copy link

codecov-io commented Dec 20, 2020

Codecov Report

Merging #945 (c57982a) into 1.5 (a347a04) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.5     #945   +/-   ##
=======================================
  Coverage   60.03%   60.04%           
=======================================
  Files         260      260           
  Lines       12855    12855           
=======================================
+ Hits         7718     7719    +1     
  Misses       4174     4174           
+ Partials      963      962    -1     
Impacted Files Coverage Δ
cluster/router/healthcheck/default_health_check.go 94.11% <ø> (ø)
protocol/dubbo/impl/hessian.go 29.17% <0.00%> (ø)
registry/zookeeper/registry.go 50.36% <0.00%> (ø)
remoting/kubernetes/listener.go 50.52% <0.00%> (-3.16%) ⬇️
cluster/router/chain/chain.go 70.63% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a347a04...c57982a. Read the comment docs.

@AlexStocks AlexStocks merged commit 9be9fef into apache:1.5 Dec 20, 2020
@zouyx zouyx added the bug Something isn't working label Dec 20, 2020
@zouyx zouyx added this to the v1.5.5 milestone Dec 20, 2020
@fangyincheng fangyincheng changed the title fix bug Fix: generic Dec 20, 2020
zouyx pushed a commit that referenced this pull request Dec 20, 2020
@zouyx zouyx mentioned this pull request Dec 20, 2020
zouyx pushed a commit that referenced this pull request Jan 4, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
@fangyincheng fangyincheng deleted the fix-object branch June 26, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants