Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: generic #945

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Fix: generic #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f269e62
fix bug
fangyincheng Dec 20, 2020
c57982a
add fmt
fangyincheng Dec 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ install: true

# define ci-stage
script:
- go fmt ./... && [[ -z `git status -s` ]]
# license-check
- make verify
# integrate-test
Expand Down
1 change: 0 additions & 1 deletion cluster/router/healthcheck/default_health_check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ func (c *DefaultHealthChecker) getCircuitBreakerSleepWindowTime(status *protocol
return int64(sleepWindow)
}


// GetRequestSuccessiveFailureThreshold return the requestSuccessiveFailureThreshold bound to this DefaultHealthChecker
func (c *DefaultHealthChecker) GetRequestSuccessiveFailureThreshold() int32 {
return c.requestSuccessiveFailureThreshold
Expand Down
4 changes: 1 addition & 3 deletions protocol/dubbo/impl/hessian.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ import (
"github.com/apache/dubbo-go/common/logger"
)

type Object interface{}

type HessianSerializer struct {
}

Expand Down Expand Up @@ -474,7 +472,7 @@ func getArgType(v interface{}) string {
return "java.lang.String"
case []string:
return "[Ljava.lang.String;"
case []Object:
case []hessian.Object:
return "[Ljava.lang.Object;"
case map[interface{}]interface{}:
// return "java.util.HashMap"
Expand Down
2 changes: 1 addition & 1 deletion registry/zookeeper/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func (r *zkRegistry) registerTempZookeeperNode(root string, node string) error {

r.cltLock.Lock()
defer r.cltLock.Unlock()
if r.client == nil{
if r.client == nil {
return perrors.WithStack(perrors.New("zk client already been closed"))
}
err = r.client.Create(root)
Expand Down