-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using method level cache, no matter what i config, it's always LruCache. #1362
Comments
it seems a bug |
有几个疑问: |
1、当前master分支 |
嗯,麻烦官方看一下,应该是个bug @kimmking |
@zhaojigang Would you like to create a PR? |
@zhaojigang |
问题出在ExtensionLoader上, 在生成的代理类中,应该使用url.getMethodParameter而不是url.getParameter |
@kimmking I will fix it. |
* remotes/upstream/master: (226 commits) clean up imports for CacheTest [Dubbo-apache#1362] cache provider always lru cache (apache#1396) Remove author info and add apache license Fix "promoteTransitiveDependencies=false" of maven-shade-plugin apache#1411: Locale deserialize 'zh-hant_CN' update README format update readme to add some details (apache#1403) fix number type is lost in yaml config file (apache#1401) fix hessian lite test case fail bug (apache#1394) Merge pull request apache#1391, fix typo of method name in qos module. Fix time unit problem related with FutureAdapter in UT Fix time unit problem related with FutureAdapter in UT Fix time unit problem in UT Fixed apache#1398, revert bugs introduced from apache#1375 Change Mailing list address Merge pull request apache#1242, remove redundant null check. Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. Merge pull request apache#1384, fix build string bug. Merge pull request apache#1376, do not instantiate load balance if there is no invokers Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. ...
* #1362修复 #1362修复 * #1362修复 #1362修复 * #1362修复 #1362修复 * 修改bug 修改bug * 修改bug 修改bug * 添加cache的测试用例 添加cache的测试用例
consumer配置:
<dubbo:reference id="demoService" check="false" interface="com.alibaba.dubbo.demo.DemoService">
<dubbo:method name="sayHello" timeout="60000" cache="threadlocal"/>
</dubbo:reference>
在执行的过程中,我们发现其实并不会创建ThreadlocalCache,而是用的LruCache,原因是在
可以看到,当将cache配置在方法上而不是服务上的时候,传入的url只有"method.cache"参数而没有"cache"参数,但是CacheFactory$Adaptive这个类并没有作区分。
The text was updated successfully, but these errors were encountered: