fix #1245

[hqq2023623]

What is the purpose of the change

fix #1245

Brief changelog

fix #1245

Verifying this change

fix #1245

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

[codecov-io]

Codecov Report

Merging #1375 into master will decrease coverage by 0.22%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
- Coverage   32.57%   32.35%   -0.23%     
==========================================
  Files         691      691              
  Lines       34537    34537              
  Branches     6812     6812              
==========================================
- Hits        11252    11173      -79     
- Misses      21357    21433      +76     
- Partials     1928     1931       +3

Impacted Files	Coverage Δ
...libaba/com/caucho/hessian/io/JavaDeserializer.java	41.52% <14.28%> (ø)	⬆️
...bo/rpc/cluster/support/FailbackClusterInvoker.java	71.79% <0%> (-12.83%)	⬇️
...mon/serialize/support/dubbo/GenericDataOutput.java	63.5% <0%> (-11.93%)	⬇️
...ba/dubbo/remoting/transport/netty/NettyClient.java	72.58% <0%> (-11.3%)	⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java	41.66% <0%> (-8.34%)	⬇️
...mmon/serialize/support/dubbo/GenericDataInput.java	57.14% <0%> (-6.57%)	⬇️
...libaba/com/caucho/hessian/util/IdentityIntMap.java	25% <0%> (-5.96%)	⬇️
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java	73.14% <0%> (-2.78%)	⬇️
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java	54.54% <0%> (-2.03%)	⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java	55.22% <0%> (-1.5%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c20d99...1b7fc08. Read the comment docs.

[chickenlj]

Good job, do you think we should merge these else statements?

[hqq2023623]

Do you mean change like this

protected static Object getParamArg(Class cl) {
        if (!cl.isPrimitive())
            return null;
        else if (boolean.class.equals(cl))
            return Boolean.FALSE;
        else if (byte.class.equals(cl) 
                || short.class.equals(cl) 
                || char.class.equals(cl) 
                || int.class.equals(cl))
            return 0;
        else if (long.class.equals(cl))
            return 0L;
        else if (float.class.equals(cl))
            return 0F;
        else if (double.class.equals(cl))
            return 0D;
        else
            throw new UnsupportedOperationException();
    }

It's ok with me to do so

[chickenlj]

Never mind, let's keep is as it is.

[zonghaishang]

@hqq2023623 @chickenlj This branch will lead to failure of the deserialization error。
com.alibaba.com.caucho.hessian.io.JavaDeserializer#getParamArg:

    protected static Object getParamArg(Class cl) {
        if (!cl.isPrimitive())
            return null;
        else if (boolean.class.equals(cl))
            return Boolean.FALSE;
        else if (byte.class.equals(cl))
            return 0;
        else if (short.class.equals(cl))
            return 0;
        else if (char.class.equals(cl))
            return 0;
        else if (int.class.equals(cl))
            return 0;
        else if (long.class.equals(cl))
            return 0L;
        else if (float.class.equals(cl))
            return 0F;
        else if (double.class.equals(cl))
            return 0D;
        else
            throw new UnsupportedOperationException();
    }

Deserialization requires parsing of constructor argument types.

My construct :

    public PersonType(String, int, double, short, byte, List<Short>) {
        this.name = name;
        this.age = age;
        this.money = money;
        this.p1 = p1;
        this.p2 = p2;
        this.p3 = p3;
    }

Please revert code.

[zonghaishang]

@hqq2023623 Before submitting the code, please make sure that all local units tested correctly and passed.

[hqq2023623]

@zonghaishang
It's my fault , I will make sure all the local unit tests are passed before submit next time.
the type mismatch exception is caused by class byte and short because the default type of 0 is Integer.
so change them to the Xxx.valueof() will resolve this

protected static Object getParamArg(Class cl) {
        if (!cl.isPrimitive())
            return null;
        else if (boolean.class.equals(cl))
            return Boolean.FALSE;
        else if (byte.class.equals(cl))
            return Byte.valueOf("0");
        else if (short.class.equals(cl))
            return Short.valueOf("0");
        else if (char.class.equals(cl))
            return '0';
        else if (int.class.equals(cl))
            return 0;
        else if (long.class.equals(cl))
            return 0L;
        else if (float.class.equals(cl))
            return 0F;
        else if (double.class.equals(cl))
            return 0D;
        else
            throw new UnsupportedOperationException();
    }

[chickenlj]

I have reverted the code, and will merge to PRs created affected with this bug.