-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move metrics from common to dubbo-metrics #11386
Conversation
@songxiaosheng PTAL |
@wxbty |
done |
Codecov Report
@@ Coverage Diff @@
## 3.2 #11386 +/- ##
============================================
- Coverage 69.46% 64.81% -4.66%
+ Complexity 119 14 -105
============================================
Files 1525 1499 -26
Lines 82581 62544 -20037
Branches 14708 9149 -5559
============================================
- Hits 57364 40536 -16828
+ Misses 20339 17777 -2562
+ Partials 4878 4231 -647
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e5cfd04
to
123478b
Compare
123478b
to
a172151
Compare
1e750cb
to
f19187d
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
The content of metrics should not be placed in the common package
Brief changelog
move to dubbo-metrics,add a separate dubbo-metrics-default package, dubbo-metrics-api only needs interfaces and javabeans