Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move metrics from common to dubbo-metrics #11386

Merged
merged 14 commits into from
Feb 1, 2023
Merged

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Jan 27, 2023

What is the purpose of the change

The content of metrics should not be placed in the common package

Brief changelog

move to dubbo-metrics,add a separate dubbo-metrics-default package, dubbo-metrics-api only needs interfaces and javabeans

@AlbumenJ
Copy link
Member

@songxiaosheng PTAL

@songxiaosheng
Copy link
Member

@wxbty
Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metrics.service.MetricsServiceExporter by name default, no related exception was found, please check whether related SPI module is missing.
at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:760)
at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:767)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:561)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:535)
at org.apache.dubbo.common.extension.ExtensionLoader.getDefaultExtension(ExtensionLoader.java:587)
at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initMetricsService(DefaultApplicationDeployer.java:356)
at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initialize(DefaultApplicationDeployer.java:212)
at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.start(DefaultApplicationDeployer.java:611)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:226)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:215)
at com.apache.dubbo.demo.graalvm.consumer.Application.runWithBootstrap(Application.java:68)
at com.apache.dubbo.demo.graalvm.consumer.Application.main(Application.java:40)
Error: Process completed with exit code 1.

@wxbty
Copy link
Member Author

wxbty commented Jan 28, 2023

@wxbty Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metrics.service.MetricsServiceExporter by name default, no related exception was found, please check whether related SPI module is missing. at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:760) at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:767) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:561) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:535) at org.apache.dubbo.common.extension.ExtensionLoader.getDefaultExtension(ExtensionLoader.java:587) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initMetricsService(DefaultApplicationDeployer.java:356) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initialize(DefaultApplicationDeployer.java:212) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.start(DefaultApplicationDeployer.java:611) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:226) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:215) at com.apache.dubbo.demo.graalvm.consumer.Application.runWithBootstrap(Application.java:68) at com.apache.dubbo.demo.graalvm.consumer.Application.main(Application.java:40) Error: Process completed with exit code 1.

done

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #11386 (6616818) into 3.2 (f73eee9) will decrease coverage by 4.66%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.2   #11386      +/-   ##
============================================
- Coverage     69.46%   64.81%   -4.66%     
+ Complexity      119       14     -105     
============================================
  Files          1525     1499      -26     
  Lines         82581    62544   -20037     
  Branches      14708     9149    -5559     
============================================
- Hits          57364    40536   -16828     
+ Misses        20339    17777    -2562     
+ Partials       4878     4231     -647     
Impacted Files Coverage Δ
...ubbo/config/deploy/DefaultApplicationDeployer.java 72.23% <ø> (-9.47%) ⬇️
...o/config/deploy/DefaultMetricsServiceExporter.java 79.48% <ø> (ø)
...a/org/apache/dubbo/metrics/event/MetricsEvent.java 57.14% <ø> (ø)
...n/java/org/apache/dubbo/metrics/event/RTEvent.java 66.66% <ø> (ø)
...a/org/apache/dubbo/metrics/event/RequestEvent.java 86.66% <ø> (ø)
...a/org/apache/dubbo/metrics/model/MethodMetric.java 67.56% <ø> (ø)
...rg/apache/dubbo/metrics/model/MetricsCategory.java 100.00% <ø> (ø)
...ava/org/apache/dubbo/metrics/model/MetricsKey.java 100.00% <ø> (ø)
.../dubbo/metrics/model/sample/GaugeMetricSample.java 100.00% <ø> (ø)
...pache/dubbo/metrics/model/sample/MetricSample.java 52.38% <ø> (ø)
... and 503 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please fix conflicts

@AlbumenJ
Copy link
Member

image

@x-shadow-man x-shadow-man force-pushed the metrics-pkg branch 2 times, most recently from e5cfd04 to 123478b Compare January 30, 2023 06:22
@wxbty wxbty requested a review from AlbumenJ January 31, 2023 03:11
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 82 Code Smells

48.7% 48.7% Coverage
0.3% 0.3% Duplication

songxiaosheng

This comment was marked as duplicate.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants