Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2.7.2] Fix the protostuff protocol lacks a custom serialization method for java.sql.Date #4384 #4386

Merged
merged 11 commits into from
Jul 3, 2019

Conversation

fitzf
Copy link
Contributor

@fitzf fitzf commented Jun 25, 2019

What is the purpose of the change

Brief changelog

  • Fix the protostuff protocol lacks a custom serialization method for java.sql.Date.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@fitzf fitzf changed the title [Dubbo-4384] Fix the protostuff protocol lacks a custom serialization method for java.sql.Date. [Dubbo-2.7.2] Fix the protostuff protocol lacks a custom serialization method for java.sql.Date #4384 Jun 25, 2019
@fitzf
Copy link
Contributor Author

fitzf commented Jun 28, 2019

Can someone help me review this PR? urgent

@fitzf
Copy link
Contributor Author

fitzf commented Jul 3, 2019

@ralf0131 @CrazyHZM @chickenlj Have time to help me review this MR? I want to use the official version 2.7.3

@codecov-io
Copy link

Codecov Report

Merging #4386 into master will increase coverage by 0.04%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4386      +/-   ##
===========================================
+ Coverage     62.95%     63%   +0.04%     
+ Complexity      452     450       -2     
===========================================
  Files           769     770       +1     
  Lines         32995   33084      +89     
  Branches       5216    5222       +6     
===========================================
+ Hits          20773   20845      +72     
- Misses         9824    9846      +22     
+ Partials       2398    2393       -5
Impacted Files Coverage Δ Complexity Δ
...ommon/serialize/protostuff/utils/WrapperUtils.java 93.93% <100%> (+0.39%) 0 <0> (ø) ⬇️
...serialize/protostuff/delegate/SqlDateDelegate.java 62.5% <62.5%> (ø) 0 <0> (?)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0%> (-4.35%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 64.75% <0%> (-2.46%) 0% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7285ce9...ca06474. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit a42fb15 into apache:master Jul 3, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
…n method for java.sql.Date apache#4384 (apache#4386)

* fix: apache#3727

* style: code tidy up

* style: add apache license

* fix: apache#3914 protostuff serialize java.sql.Timestamp

* fix: add SqlDateDelegate to fix protostuff custon serialize java.sql.Date

fix apache#4384
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
…n method for java.sql.Date apache#4384 (apache#4386)

* fix: apache#3727

* style: code tidy up

* style: add apache license

* fix: apache#3914 protostuff serialize java.sql.Timestamp

* fix: add SqlDateDelegate to fix protostuff custon serialize java.sql.Date

fix apache#4384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Protostuff serialization protocol not support for java.sql.Date
3 participants