-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-2.7.2] Fix the protostuff protocol lacks a custom serialization method for java.sql.Date #4384 #4386
Conversation
upgrade slf4j & logback & fastjson
sync origin
merge origin
PULL origin
Pull origin
Can someone help me review this PR? urgent |
@ralf0131 @CrazyHZM @chickenlj Have time to help me review this MR? I want to use the official version 2.7.3 |
Codecov Report
@@ Coverage Diff @@
## master #4386 +/- ##
===========================================
+ Coverage 62.95% 63% +0.04%
+ Complexity 452 450 -2
===========================================
Files 769 770 +1
Lines 32995 33084 +89
Branches 5216 5222 +6
===========================================
+ Hits 20773 20845 +72
- Misses 9824 9846 +22
+ Partials 2398 2393 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n method for java.sql.Date apache#4384 (apache#4386) * fix: apache#3727 * style: code tidy up * style: add apache license * fix: apache#3914 protostuff serialize java.sql.Timestamp * fix: add SqlDateDelegate to fix protostuff custon serialize java.sql.Date fix apache#4384
…n method for java.sql.Date apache#4384 (apache#4386) * fix: apache#3727 * style: code tidy up * style: add apache license * fix: apache#3914 protostuff serialize java.sql.Timestamp * fix: add SqlDateDelegate to fix protostuff custon serialize java.sql.Date fix apache#4384
What is the purpose of the change
Brief changelog
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.