-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] JsonRpcProtocol support Generalization #4595 #4596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4596 +/- ##
============================================
- Coverage 63.96% 63.94% -0.02%
- Complexity 452 457 +5
============================================
Files 769 771 +2
Lines 33206 33248 +42
Branches 5237 5241 +4
============================================
+ Hits 21239 21261 +22
- Misses 9546 9561 +15
- Partials 2421 2426 +5
Continue to review full report at Codecov.
|
# Conflicts: # dubbo-rpc/dubbo-rpc-jsonrpc/src/main/java/org/apache/dubbo/rpc/protocol/jsonrpc/JsonRpcProtocol.java # dubbo-rpc/dubbo-rpc-jsonrpc/src/test/java/org/apache/dubbo/rpc/protocol/jsonrpc/JsonRpcProtocolTest.java
|
# Conflicts: # dubbo-rpc/dubbo-rpc-http/src/test/java/org/apache/dubbo/rpc/protocol/http/HttpProtocolTest.java
@CrazyHZM 这个 |
What is the purpose of the change
JsonRpcProtocol support Generalization #4595
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.