Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4351]Fix getRemoteApplicationName() returns null #4351 #4722

Merged
merged 5 commits into from
Sep 7, 2019

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Aug 2, 2019

What is the purpose of the change

Fix RpcContext.getContext().getRemoteApplicationName() returns null #4351

In addition to jsonrpc, xmlrpc, webservice, thrift, others support RpcContext.getContext().getRemoteApplicationName().

Because jsonrpc, xmlrpc, webservice ,thrift do not support attachment.

Jsonrpc supports attachment I have done this in #4596, please review.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

# Conflicts:
#	dubbo-rpc/dubbo-rpc-http/src/test/java/org/apache/dubbo/rpc/protocol/http/HttpProtocolTest.java
@cvictory cvictory added this to the 2.7.4 milestone Sep 4, 2019
@cvictory
Copy link
Contributor

cvictory commented Sep 4, 2019

@CrazyHZM There are some conflict in this pr

# Conflicts:
#	dubbo-rpc/dubbo-rpc-rest/src/test/java/org/apache/dubbo/rpc/protocol/rest/DemoServiceImpl.java
@CrazyHZM
Copy link
Member Author

CrazyHZM commented Sep 4, 2019

@CrazyHZM There are some conflict in this pr

Done.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beiwei30 beiwei30 merged commit c536eec into apache:master Sep 7, 2019
@CrazyHZM CrazyHZM deleted the remoteApp branch March 11, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants