Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make remote application effect on consumer side too #5029

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Sep 7, 2019

What is the purpose of the change

make sure RpcContext.getContext().getRemoteApplication() returns provider's app name on client side. It may useful when a custom filter is implemented.

a follow up for pull request #4722

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from CrazyHZM September 7, 2019 16:15
@codecov-io
Copy link

Codecov Report

Merging #5029 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5029      +/-   ##
============================================
+ Coverage     63.88%   63.95%   +0.06%     
- Complexity      450      453       +3     
============================================
  Files           769      769              
  Lines         33147    33182      +35     
  Branches       5206     5232      +26     
============================================
+ Hits          21177    21222      +45     
+ Misses         9549     9544       -5     
+ Partials       2421     2416       -5
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/filter/ConsumerContextFilter.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0%> (-2%) 0% <0%> (ø)
.../main/java/org/apache/dubbo/qos/textui/TTable.java 83.79% <0%> (-0.87%) 0% <0%> (ø)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (-0.26%) 31% <0%> (ø)
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 78.04% <0%> (-0.2%) 0% <0%> (ø)
...mon/src/main/java/org/apache/dubbo/common/URL.java 50.22% <0%> (-0.08%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (ø) 29% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c536eec...a7e1dbb. Read the comment docs.

@cvictory cvictory merged commit 9f4d805 into apache:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants