Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): only bolder when line width in normal state is larger than 0. #13501

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Don't bolder when the line width in the normal state is 0.

Fixed issues

N/A.

Details

If users specify the line width in the normal state as 0, the bolder logic should be skipped.

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

See test/line-boldWhenHover.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 28, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart
Copy link
Member Author

@pissang Moreover, let's have a look at another case area-large.html. There is only one series and its data is large, for a better visual experience, should we also avoid the 'bolder' logic? 'bolder' is more suitable for multiple series with the blur scope.

@pissang
Copy link
Contributor

pissang commented Oct 28, 2020

@plainheart I think it will be definitely better. But I can't think of a general design to solve issues like this currently.

@pissang pissang merged commit afc994e into release Oct 28, 2020
@echarts-bot
Copy link

echarts-bot bot commented Oct 28, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-line-bold branch October 28, 2020 11:37
@pissang
Copy link
Contributor

pissang commented Oct 28, 2020

@plainheart Or should we disable border on emphasis by default? I'm not sure which is better in a normal scenario.

plainheart added a commit that referenced this pull request Mar 11, 2021
- only make line bolder when there is more than one series and blur state
- or the user manually specify `lineStyle.width` as `bolder`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants