Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(line): tweak default line bolder logic. #14448

Closed
wants to merge 2 commits into from

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Mar 11, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR is intended to tweak the default bolder logic of the line series.

  • The line won't be bolder again in emphasis state by default
  • Only make line bolder when there are more than one series and emphasis.focus is enabled
  • Or the user manually specify lineStyle.width as bolder

Please refer to #13501 and #13013 for more details.

Fixed issues

Details

Before: What was the problem?

It's unnecessary for some cases to make the line bolder.
bolder is more suitable for multiple series with the blur scope.

After: How is it fixed in this PR?

See above.

Usage

Are there any API changes?

  • The API has been changed.

The new semantic value bolder for emphasis.lineStyle.width brought by #13013 has not been added to the document yet.

Related test cases or examples to use the new APIs

test/area-large.html
test/line-boldWhenHover.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

- only make line bolder when there is more than one series and blur state
- or the user manually specify `lineStyle.width` as `bolder`
@echarts-bot
Copy link

echarts-bot bot commented Mar 11, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant