Skip to content

Conversation

@susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 4, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add back missing tooltip opotions

Fixed issues

Close #14211

Details

Before: What was the problem?

Screen Shot 2021-02-05 at 00 10 41

Screen Shot 2021-02-05 at 00 09 57

After: How is it fixed in this PR?

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

new-tooltip.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 4, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecomfe/zrender#717 may not be necessary.

@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 5, 2021

@plainheart Hi, Could you take a look again.

@susiwen8 susiwen8 requested a review from plainheart February 6, 2021 02:22
@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 6, 2021

@plainheart @pissang Hi, please review it.

@susiwen8 susiwen8 requested a review from plainheart February 7, 2021 03:43
@plainheart
Copy link
Member

It seems there are some conflicting files. Perhaps, we could go ahead to fix them in 5.1.1 or 5.2.0.

@pissang pissang added this to the 5.2.0 milestone Apr 20, 2021
@susiwen8 susiwen8 requested a review from pissang July 20, 2021 15:18
@gtzinos
Copy link

gtzinos commented Mar 21, 2022

in which version is it fixed? I have the 5.2.2 and still is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tooltip.textStyle.width It doesn't work.

4 participants