Skip to content

chore: add none to textStyle overflow #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pissang merged 1 commit into from
Feb 5, 2021
Merged

chore: add none to textStyle overflow #717

pissang merged 1 commit into from
Feb 5, 2021

Conversation

@susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 4, 2021 •
edited
Loading

@pissang
Copy link
Contributor

pissang commented Feb 5, 2021 •
edited
Loading

Seems we don't handle 'none' currently. null is used to disable overflow

@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 5, 2021

Seems we don't handle 'none' currently. null is used to disable overfull

@pissang should we remove 'none' in doc?

@pissang
Copy link
Contributor

pissang commented Feb 5, 2021 •
edited
Loading

Seems 'none' also makes sense and won't have problem in the code.

@pissang pissang merged commit 960c500 into ecomfe:master Feb 5, 2021
@susiwen8 susiwen8 deleted the textStyle-overflow-type branch February 5, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pissang pissang pissang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@susiwen8 @pissang