Skip to content

Conversation

AbhishekPSingh07
Copy link
Contributor

Fixes #4025 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@harshithasudhakar harshithasudhakar changed the title fixed #4025 [ISSUE #4025] Comparison using reference equality instead of value equality Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4387 (730593d) into master (50d6113) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 730593d differs from pull request most recent head 3f19a30. Consider uploading reports for the commit 3f19a30 to get more accurate results

@@            Coverage Diff            @@
##             master    #4387   +/-   ##
=========================================
  Coverage     17.85%   17.85%           
  Complexity     1514     1514           
=========================================
  Files           602      602           
  Lines         25518    25518           
  Branches       2400     2400           
=========================================
  Hits           4555     4555           
  Misses        20524    20524           
  Partials        439      439           
Files Changed Coverage Δ
...otocol/catalog/protos/QueryOperationsResponse.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 3d4e922 into apache:master Aug 22, 2023
@AbhishekPSingh07
Copy link
Contributor Author

Hey @xwm1992 @mxsm @Pil0tXia. I am new to open-source projects. I have contributed to small projects and am confident in Java language could you please refer me some resources so that I can understand and contribute more to this repo.

@Pil0tXia
Copy link
Member

Pil0tXia commented Aug 22, 2023

@AbhishekPSingh07 Thank you for your contribution. The message retry logics are currently separated in each protocol (such as org.apache.eventmesh.runtime.core.protocol.http.retry.HttpRetryer), and you may abstract them if you are interested.

You may refer to these two PRs and collaborate with them:
#4061
#4179

@AbhishekPSingh07
Copy link
Contributor Author

ok will give it a go

xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Comparison using reference equality instead of value equality.[QueryOperationsResponse]
4 participants