Skip to content

[ISSUE #4025] Comparison using reference equality instead of value equality #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[ISSUE #4025] Comparison using reference equality instead of value equality #4387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ain/java/org/apache/eventmesh/common/protocol/catalog/protos/QueryOperationsResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public static Builder newBuilder(QueryOperationsResponse prototype) {

@Override
public Builder toBuilder() {
return this == DEFAULT_INSTANCE
return this.equals(DEFAULT_INSTANCE)
? new Builder() : new Builder().mergeFrom(this);
}

Expand Down Expand Up @@ -481,7 +481,7 @@ public Builder mergeFrom(com.google.protobuf.Message other) {
}

public Builder mergeFrom(QueryOperationsResponse other) {
if (other == QueryOperationsResponse.getDefaultInstance()) {
if (other.equals(QueryOperationsResponse.getDefaultInstance())) {
return this;
}
if (operationsBuilder_ == null) {
Expand Down