[ISSUE #4845] Update grpc version from 1.43.2 to 1.63.0 #4876
Conversation
OK |
| eventMesh.sysid=0000 | ||
| eventMesh.server.tcp.port=10000 | ||
| eventMesh.server.tcp.port=10002 | ||
| eventMesh.server.http.port=10105 |
| # storage plugin | ||
| eventMesh.storage.plugin.type=standalone | ||
| eventMesh.storage.plugin.type=rocketmq | ||
|
|
||
| ##connector plugin | ||
| #eventMesh.connector.plugin.type=rocketmq | ||
|
|
install.sh
Outdated
| gradle clean -Pdev=true -Pjdk=1.8 dist tar zip | ||
|
|
||
| gradlew installPlugin | ||
| # package jar | ||
| gradle clean -Pdev=true -Pjdk=1.8 jar No newline at end of file | ||
| #gradle clean -Pdev=true -Pjdk=1.8 jar |
There was a problem hiding this comment.
This script seems to be getting old, you can just delete this script. If you want to build the project, please refer to this documentation.
|
|
||
| def grpcVersion = '1.43.2' // CURRENT_GRPC_VERSION | ||
| def protobufVersion = '3.21.5' | ||
| def grpcVersion = '1.63.0' // CURRENT_GRPC_VERSION | ||
| def protobufVersion = '3.25.1' | ||
| def protocVersion = protobufVersion |
There was a problem hiding this comment.
I think we just need to define grpcVersion and protobufVersion once in the build.gradle file in the project root directory.
There was a problem hiding this comment.
I also think it's more appropriate to define it under the root directory. I will resubmit to fix the above issues.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4876 +/- ##
============================================
+ Coverage 15.91% 16.47% +0.56%
- Complexity 1734 1819 +85
============================================
Files 897 910 +13
Lines 31982 32363 +381
Branches 2737 2787 +50
============================================
+ Hits 5089 5331 +242
- Misses 26413 26520 +107
- Partials 480 512 +32 ☔ View full report in Codecov by Sentry. |
|
Please resolve conflicts. |
|
May I ask that is this PR ready for review? |
There was a problem hiding this comment.
I see your latest commit. The master branch has received a lot of dependabot upgrades to dependencies, so the grpc version is already at the expected version. However, the grpcVersion field is still not standardized and lacks management. You can improve on this.
May I inquire if you have any questions? |
I have a look at the content of the master branch, I will push it again. |
Fixes #4845
Motivation
update grpc version and protobuf version
Modifications
Describe the modifications you've done.
Documentation