[ISSUE #4845] Apply dependency management to grpcVersion and protobufVersion.
#4988
Conversation
Pil0tXia
changed the title
grpcVersion and protobufVersion.
Pil0tXia
added
the
waiting for contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4988 +/- ##
=========================================
Coverage 15.64% 15.64%
Complexity 1777 1777
=========================================
Files 1001 1001
Lines 33777 33777
Branches 2917 2917
=========================================
Hits 5284 5284
Misses 27975 27975
Partials 518 518 ☔ View full report in Codecov by Sentry. |
build.gradle
Outdated
| def opentelemetryVersion = '1.36.0' | ||
| def cloudeventsVersion = '3.0.0' | ||
| def cloudeventsVersion = '2.5.0' | ||
| def curatorVersion = '5.7.0' |
build.gradle
Outdated
| dependency "org.springframework.boot:spring-boot-starter-jetty:2.7.18" | ||
|
|
||
| dependency "com.google.protobuf:protobuf-java-util:${protobufVersion}" | ||
| dependency "com.google.protobuf:protobuf-java:${protobufVersion}" | ||
| dependency "com.google.protobuf:protoc:${protocVersion}" | ||
|
|
||
| dependency "com.mysql:mysql-connector-j:8.4.0" |
There was a problem hiding this comment.
The google.protobuf dependencies should be placed after the grpc dependencies. The same as the protobufVersion var.
| def protobufVersion = '3.25.3' | ||
| def protocVersion = protobufVersion | ||
|
|
There was a problem hiding this comment.
Redundant protobufVersion field.
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #4845
Previous PR: #4876
Motivation
update grpc version and protobuf version
Modifications
Describe the modifications you've done.
Documentation