Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Guava version to 31 and Flink to 1.18 #2463

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Change Guava version to 31 and Flink to 1.18 #2463

merged 10 commits into from
Nov 14, 2023

Conversation

maver1ck
Copy link
Contributor

@maver1ck maver1ck commented Sep 5, 2023 •
edited
Loading

Upgrade Guava to version 31 to get compatibility with Flink 1.18

@maver1ck maver1ck mentioned this pull request Sep 5, 2023
Closed
2 tasks
@maver1ck maver1ck changed the title Change Guava version to 31 WIP: Change Guava version to 31 Sep 6, 2023
@gtk96
Copy link
Contributor

gtk96 commented Oct 26, 2023

@maver1ck flink 1.18 already released

@maver1ck
Copy link
Contributor Author

@gtk96 PR rebased, let's check tests

@maver1ck
Copy link
Contributor Author

@gtk96
Any idea why those tests are failing ? Looks like timeout not related to PR.

@gtk96
Copy link
Contributor

gtk96 commented Oct 26, 2023

@gtk96 Any idea why those tests are failing ? Looks like timeout not related to PR.

I read the log. I think you are right. There are other reasons for the error. cc @GOODBOY008 @ruanhang1993

@maver1ck maver1ck changed the title WIP: Change Guava version to 31 Change Guava version to 31 and Flink to 1.18 Oct 26, 2023
@Kakaeex
Copy link

Kakaeex commented Oct 31, 2023

Look forward to your good news. when upgrade to jdk17，so many Plug-ins need to upgrade

@maver1ck
Copy link
Contributor Author

@Kakaeex Were you able to compile this repo in Java 17 ? I'm using still Java 11 and Java 17 only for Flink jobs.

@gtk96 gtk96 mentioned this pull request Nov 9, 2023
Closed
2 tasks
@Jiabao-Sun
Copy link
Contributor

Thanks @maver1ck for this great work and sorry for the late review.
Would you mind to resolve the conflicts?

We can refer to the PR that bumped version to 1.17 #2057.

@maver1ck
Copy link
Contributor Author

maver1ck commented Nov 9, 2023 •
edited
Loading

@Jiabao-Sun
I rebased this PR, but I think some more work needed to be done later on (like adding 1.18 to test envs)

@Jiabao-Sun
Copy link
Contributor

The CI fails, it seems that we have ignored some newly added classes.

By the way, can we add version 1.18 in the E2E test?
https://github.com/ververica/flink-cdc-connectors/blob/80dfc515a1ec26c3a1d46aa6cbc7264d0ff3a8c9/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/com/ververica/cdc/connectors/tests/utils/FlinkContainerTestEnvironment.java#L125-L131

https://github.com/ververica/flink-cdc-connectors/blob/80dfc515a1ec26c3a1d46aa6cbc7264d0ff3a8c9/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/pom.xml#L28-L36

Jiabao-Sun
Jiabao-Sun reviewed Nov 9, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@maver1ck
Copy link
Contributor Author

maver1ck commented Nov 9, 2023 •
edited
Loading

@Jiabao-Sun
Fixed compilation at least. Let's check ITs

@maver1ck
Copy link
Contributor Author

maver1ck commented Nov 9, 2023

OK. I think we have missing dependency on jdbc-connector_1.18.0.jar.
AFAIK there is no version of JDBC connector for 1.18.0. Let me add PR in their repo.

@maver1ck
Copy link
Contributor Author

maver1ck commented Nov 9, 2023 •
edited
Loading

We are blocked by apache/flink-connector-jdbc#76, but I'm trying to use flink jdbc 1.17 in IT.
EDIT: without success. @Jiabao-Sun any ideas ?

@Jiabao-Sun Jiabao-Sun linked an issue Nov 10, 2023 that may be closed by this pull request
[Build] Bump Flink version to 1.18.0 #2670
Closed
2 tasks
@leonardBang leonardBang self-requested a review November 10, 2023 14:21
leonardBang
leonardBang approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maver1ck for the contribution , @gtk96 and @Jiabao-Sun for the review work, LGTM

@leonardBang leonardBang merged commit 1e6b983 into apache:master Nov 14, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@maver1ck
[build] Bump Flink version to 1.18.0 (apache#2463)
fff2f84 
This closes apache#2670.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiabao-Sun Jiabao-Sun Jiabao-Sun left review comments

@gtk96 gtk96 gtk96 left review comments

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build] Bump Flink version to 1.18.0
5 participants
@maver1ck @gtk96 @Kakaeex @Jiabao-Sun @leonardBang