Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33378] Prepare actions for flink version 1.18 #76

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

eskabetxe
Copy link
Member

@eskabetxe eskabetxe commented Oct 27, 2023

Changes made:

  • downgrade flink version on pom to match rule of minimum supported version
  • added validation on PRs for 1.16 (this is already on weekly)
  • bump version from 1.18-SNAPSHOT to 1.18.0 on all gitactions
  • bump the version of some test dependencies as Junit5, assertj, testcontainers and mockito

Note:

  • version 1.19-SNAPSHOT is not added to CI because of this

pom.xml Outdated Show resolved Hide resolved
@eskabetxe eskabetxe force-pushed the FLINK-33378 branch 2 times, most recently from b4c668e to b50691c Compare October 27, 2023 11:25
@eskabetxe eskabetxe changed the title [FLINK-33378] Bump flink version to 1.18 [FLINK-33378] Prepare actions for flink version 1.18 Oct 27, 2023
@maver1ck
Copy link
Contributor

maver1ck commented Nov 9, 2023

@MartijnVisser any chance to merge this ?

pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@eskabetxe eskabetxe requested a review from snuyanzin November 22, 2023 13:13
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@eskabetxe eskabetxe force-pushed the FLINK-33378 branch 3 times, most recently from 51a4898 to f3082df Compare November 22, 2023 13:55
@eskabetxe
Copy link
Member Author

I have a problem now..
This was merged: https://issues.apache.org/jira/browse/FLINK-29541

Basically this class TableTestBase have been migrated to junit5, and this makes JdbcTablePlanTest fail on 1.19-SNAPSHOT

@snuyanzin any guidance? can I remove 1.19-SNAPSHOT to allow this to be merged?

@eskabetxe eskabetxe requested a review from snuyanzin November 22, 2023 14:22
@snuyanzin
Copy link
Contributor

can I remove 1.19-SNAPSHOT to allow this to be merged?

yes, I think we could it split it into some subtasks

@eskabetxe
Copy link
Member Author

@snuyanzin removed the 1.19-SNAPSHOT from PRs and Weekly.. all green

@snuyanzin
Copy link
Contributor

great, thanks
can you also change PR's description to match changes within this PR?

@eskabetxe
Copy link
Member Author

can you also change PR's description to match changes within this PR?

done

@snuyanzin
Copy link
Contributor

snuyanzin commented Nov 22, 2023

@MartijnVisser are you ok or you'd like to have anything else improved?
(asking since you are marked as one who requested changes)

@snuyanzin
Copy link
Contributor

ok, let's merge it

@snuyanzin snuyanzin merged commit 79e7509 into apache:main Nov 26, 2023
@eskabetxe eskabetxe deleted the FLINK-33378 branch November 27, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants