[FLINK-16557][docs] Document YAML-ized Kafka egresses / ingresses in … #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzulitai
approved these changes
Mar 22, 2020
There was a problem hiding this comment.
Looks good, thanks a lot for writing this up @sjwiesman.
Only found minor problems with indentation and typos, I'll address those when merging!
Comment on lines
+66
to
+67
| ingresses: | ||
| - ingress: |
There was a problem hiding this comment.
Indentation seems a bit off here:
Suggested change
| ingresses: | |
| - ingress: | |
| ingresses: | |
| - ingress: |
Comment on lines
+135
to
+136
| egresses: | ||
| - egress: |
Comment on lines
+82
to
+83
| topics: | ||
| - topic: messages-1 |
There was a problem hiding this comment.
Indentation:
Suggested change
| topics: | |
| - topic: messages-1 | |
| topics: | |
| - topic: messages-1 |
|
|
||
| .. code-block:: none | ||
|
|
||
| KafkaEgressBuilder#withNoProducerSemantics(); |
There was a problem hiding this comment.
This should be KafkaEgressBuilder#withAtLeastOnceSemantics
| .. code-block:: yaml | ||
|
|
||
| deliverySemantic: | ||
| type: none |
There was a problem hiding this comment.
Should be type: at-least-once
|
|
||
| The Kafka egress needs to know how to turn Java objects into binary data. | ||
| When using the Java pi, the Kafka egress needs to know how to turn Java objects into binary data. |
There was a problem hiding this comment.
Suggested change
| When using the Java pi, the Kafka egress needs to know how to turn Java objects into binary data. | |
| When using the Java api, the Kafka egress needs to know how to turn Java objects into binary data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Stateful Functions documentation