-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16700][docs] Document Kinesis I/O Module #65
Conversation
1acca89
to
e90f1f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just some minor comments here, will address while merging!
Thanks Seth!
ingresses: | ||
- ingress: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is off:
ingresses: | |
- ingress: | |
ingresses: | |
- ingress: |
- stream: stream-1 | ||
typeUrl: com.googleapis/com.mycomp.foo.Message | ||
targets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- stream: stream-1 | |
typeUrl: com.googleapis/com.mycomp.foo.Message | |
targets: | |
- stream: stream-1 | |
typeUrl: com.googleapis/com.mycomp.foo.Message | |
targets: |
This PR builds on #63 because it shares some yaml introduction so only the last commit is relevant. I went ahead and included the yaml configurations from #64 .