Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16700][docs] Document Kinesis I/O Module #65

Closed
wants to merge 4 commits into from

Conversation

sjwiesman
Copy link
Contributor

@sjwiesman sjwiesman commented Mar 20, 2020

This PR builds on #63 because it shares some yaml introduction so only the last commit is relevant. I went ahead and included the yaml configurations from #64 .

@sjwiesman sjwiesman force-pushed the kinesis branch 2 times, most recently from 1acca89 to e90f1f6 Compare March 20, 2020 15:41
Copy link
Contributor

@tzulitai tzulitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just some minor comments here, will address while merging!
Thanks Seth!

Comment on lines +72 to +73
ingresses:
- ingress:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off:

Suggested change
ingresses:
- ingress:
ingresses:
- ingress:

Comment on lines +88 to +90
- stream: stream-1
typeUrl: com.googleapis/com.mycomp.foo.Message
targets:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- stream: stream-1
typeUrl: com.googleapis/com.mycomp.foo.Message
targets:
- stream: stream-1
typeUrl: com.googleapis/com.mycomp.foo.Message
targets:

@tzulitai tzulitai closed this in 286a5af Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants