-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) #25794
Conversation
Looks like the build failure is related to this PR:
|
@mehdid93 are you ok to look into this ? |
Hey Robert and David and sorry for the late response.
|
If I understand correctly that the version upgrade is mainly vulnarabilities-related (please update the https://issues.apache.org/jira/browse/FLINK-36739 with the description), should we also try to make it part of 1.19.2 which we are currently working on? |
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
85375dd
to
30b7551
Compare
@flinkbot run azure |
30b7551
to
fea2ff6
Compare
@afedulov Thank a lot! I've rebased this PR should be fine now |
I actually already took the liberty to rebase your remote branch hence the CI for this particular PR is green: My ask is more for the remaining open PRs: https://issues.apache.org/jira/browse/FLINK-36716?focusedCommentId=17907318&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17907318 |
@afedulov Ah sorry I've misunderstand you, yes once this PR is merged I'll rebase both of PRs since this is a must for the next step |
Unmodified backport of #25670 to 1.20
Contribute-to: https://issues.apache.org/jira/browse/FLINK-36901
What is the purpose of the change
This pull request raises the version of the NodeJS module which is a pre-requisite to upgrade dependencies in order to address vulnerabilities in Runtime/WebFrontend component.
There will be another PR to fix vulnerabilities once this is merged.
Brief change log
NodeJS is v22.11.0/Npm is 10.9.0
Verifying this change
The Flink UI should be accessible without any difference
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation