Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) #25794

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mehdid93
Copy link
Contributor

@mehdid93 mehdid93 commented Dec 13, 2024

Unmodified backport of #25670 to 1.20
Contribute-to: https://issues.apache.org/jira/browse/FLINK-36901

What is the purpose of the change

This pull request raises the version of the NodeJS module which is a pre-requisite to upgrade dependencies in order to address vulnerabilities in Runtime/WebFrontend component.
There will be another PR to fix vulnerabilities once this is merged.

Brief change log

NodeJS is v22.11.0/Npm is 10.9.0

Verifying this change

The Flink UI should be accessible without any difference

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@mehdid93 mehdid93 changed the title [FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [BP][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) Dec 13, 2024
@mehdid93 mehdid93 changed the title [BP][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) Dec 13, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 13, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@rmetzger
Copy link
Contributor

Looks like the build failure is related to this PR:

16:06:30.274 [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:npm (npm install) on project flink-runtime-web: Failed to run task: 'npm ci --cache-max=0 --no-save ${npm.proxy}' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

@davidradl
Copy link
Contributor

@mehdid93 are you ok to look into this ?

@mehdid93
Copy link
Contributor Author

mehdid93 commented Dec 20, 2024

Hey Robert and David and sorry for the late response.
Yes the issue is due to the old version of Ubuntu image used in the build CI I've backported the PRs made by @zentol and @simplejason in this release-1.20 branch.
The list of all the PRs are (should be merged incrementally):

  1. [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) #25827 Update CI to Ubuntu 22.04 (Jammy)
  2. [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) #25794 Update the NodeJS to v22.11.0 (LTS)
  3. [BP-1.20][FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 #25829 Update ng-zorro-antd to v18
  4. [BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities #25830 Update frontend dependencies to address vulnerabilities

@afedulov
Copy link
Contributor

afedulov commented Dec 20, 2024

If I understand correctly that the version upgrade is mainly vulnarabilities-related (please update the https://issues.apache.org/jira/browse/FLINK-36739 with the description), should we also try to make it part of 1.19.2 which we are currently working on?

@afedulov
Copy link
Contributor

afedulov commented Jan 3, 2025

@flinkbot run azure

1 similar comment
@afedulov
Copy link
Contributor

afedulov commented Jan 4, 2025

@flinkbot run azure

@afedulov
Copy link
Contributor

afedulov commented Jan 6, 2025

@flinkbot run azure

@afedulov
Copy link
Contributor

afedulov commented Jan 7, 2025

@mehdid93 after the Ubunty jammy PR has been merged, this PR's CI is green. Could you please rebase the rest of the PRs you lister here on the latest release-1.20 and rerun them?

@mehdid93
Copy link
Contributor Author

mehdid93 commented Jan 7, 2025

@afedulov Thank a lot! I've rebased this PR should be fine now

@afedulov
Copy link
Contributor

afedulov commented Jan 7, 2025

I actually already took the liberty to rebase your remote branch hence the CI for this particular PR is green:
30b7551 Azure: SUCCESS
image

My ask is more for the remaining open PRs: https://issues.apache.org/jira/browse/FLINK-36716?focusedCommentId=17907318&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17907318

@mehdid93
Copy link
Contributor Author

mehdid93 commented Jan 7, 2025

@afedulov Ah sorry I've misunderstand you, yes once this PR is merged I'll rebase both of PRs since this is a must for the next step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants