-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) #25827
Conversation
The reason for not proceeding here was summarized in this FLINK-34194 comment. We ran into some problems with the docs generation with the updated CI Docker image version (due to Maven being used instead of the Maven wrapper). I just reverted the change rather than fixing it due to time constraints on my side. |
Yes, @zentol picked it up to help fixing FLINK-36716. He pushed another Docker image that still provides the Maven binaries. I'm going to close this PR to avoid confusion. We might want to create backports for 03ab6a7 if we need to fix the issue in the other release branches as well. |
@XComp got it thanks. I think there was some misunderstanding since this PR contained the aforementioned commit from Chesnay with some modifications and a follow-up commit that reverted them, so effectively it is exactly the backport of what we have on master. I will open a clean backport PR to avoid confusion. |
Oops, that was my mistake. I didn't check the author of the commit 🤦 I assumed it was an old PR that was created by me. Sorry for the confusion. I reopened the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport PR looks good 👍 I guess, we can use this one (after squashing the commits) and don't need to create a new PR here.
Any objections from your end, @afedulov ?
I am not quite sure what to read into this comment: #25708 (comment) |
If that is the case than LGTM, the second commit reverts back to 8 after resolving conflicts initially |
Yes, only with 2.0 (current |
@XComp I retriggered a follow-up PR after this one has been merged: |
The CI build you are referring to does not contain the fixes of this FLINK-34194 1.20 backport PR, AFAIS. The CI build refers to this branch (the link can be gathered from the CI run's main page). That branch has this git history which does not contain any commit of mentioning FLINK-34194 |
Oh, of course, makes sense. |
* Update CI to Ubuntu 22.04 (Jammy) --------- Co-authored-by: Chesnay Schepler <chesnay@apache.org>
* Update CI to Ubuntu 22.04 (Jammy) --------- Co-authored-by: Chesnay Schepler <chesnay@apache.org>
* Update CI to Ubuntu 22.04 (Jammy) --------- Co-authored-by: Chesnay Schepler <chesnay@apache.org>
What is the purpose of the change
This PR backport the changes done of the PR made by @zentol (#25708) in master for version 1.20.X to be used in dependencies upgrade.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation