Skip to content

Conversation

@tillrohrmann
Copy link
Contributor

What is the purpose of the change

Port TaskManagerFailsWithSlotSharingITCase to new code base.

This PR is based on #7690.

Brief change log

  • "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination
  • "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination

This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing.

Verifying this change

  • executed changed tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
    • Approved by @GJL [committer]
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
    • Approved by @GJL [committer]
  • ❔ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
    • Approved by @GJL [committer]
  • ✅ 5. Overall code [quality] is good.
    • Approved by @GJL [committer]

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

…ctInvokables

Moves the testing Sender and Receiver class from JobExecutionITCase to TestingAbstractInvokables
for easier reusability.
…w code base

- "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination
- "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination

This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing.
Copy link
Member

@GJL GJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GJL
Copy link
Member

GJL commented Feb 18, 2019

@flinkbot approve all

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @GJL. Merging after rebase.

tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 18, 2019
…w code base

- "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination
- "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination

This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing.

This closes apache#7693.
@tillrohrmann tillrohrmann deleted the FLINK-11592 branch February 18, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants