-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-11592][tests] Port TaskManagerFailsWithSlotSharingITCase to new code base #7693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsBot commandsThe @flinkbot bot supports the following commands:
|
fa129e4 to
9f2bd5b
Compare
9f2bd5b to
7dc7de4
Compare
…ctInvokables Moves the testing Sender and Receiver class from JobExecutionITCase to TestingAbstractInvokables for easier reusability.
…w code base - "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination - "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing.
7dc7de4 to
2ef1e9a
Compare
GJL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@flinkbot approve all |
|
Thanks for the review @GJL. Merging after rebase. |
…w code base - "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination - "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing. This closes apache#7693.
What is the purpose of the change
Port
TaskManagerFailsWithSlotSharingITCaseto new code base.This PR is based on #7690.
Brief change log
This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing.
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation