[FLINK-10540] Remove legacy FlinkMiniCluster and sub classes #7694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsBot commandsThe @flinkbot bot supports the following commands:
|
tisonkun
approved these changes
Feb 14, 2019
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
+1 for the removal and it will unblock several removals of legacy code in "client" componenet.
tillrohrmann
force-pushed
the
FLINK-10540
branch
from
46c6ca5 to
a4be2ac
Compare
tillrohrmann
force-pushed
the
FLINK-10540
branch
2 times, most recently
from
f82200e to
1a766c9
Compare
Contributor
Author
…ctInvokables Moves the testing Sender and Receiver class from JobExecutionITCase to TestingAbstractInvokables for easier reusability.
…w code base - "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination - "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing. This closes apache#7693.
This commit removes - FlinkMiniCluster - LocalFlinkMiniCluster - TestingCluster This closes apache#7694.
tillrohrmann
force-pushed
the
FLINK-10540
branch
from
1a766c9 to
c3b339c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove legacy
FlinkMiniClusterand sub classes.This PR is based on #7693.
Brief change log
This commit removes
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation