[FLINK-11645] Remove legacy JobManager #7731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsBot commandsThe @flinkbot bot supports the following commands:
|
This was referenced Feb 18, 2019
GJL
reviewed
Feb 18, 2019
...-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerRegistrationTest.java
Outdated
Show resolved
Hide resolved
GJL
approved these changes
Feb 18, 2019
| public String toString() { | ||
| return String.format("Trigger Checkpoint %d@%d for (%s/%s)", | ||
| getCheckpointId(), getTimestamp(), getJob(), getTaskExecutionId()); | ||
| return String.format( |
Member
There was a problem hiding this comment.
nit: checkstyle hotfix not related to removing legacy JobManager.
Contributor
Author
There was a problem hiding this comment.
True, I'll make it a separate commit.
TestingUtils#createJobManager created a TestingJobManager for testing purposes which is no longer needed since all legacy tests using the TestingJobManager are now ported.
…ved to TestingTaskManagerMessages
Removes the TestingJobManager, TestingJobManagerLike and TestingJobManagerMessages.
tillrohrmann
force-pushed
the
removeJobManager
branch
from
169df31 to
c94e7a7
Compare
This commit removes the legacy JobManager and references in comments from the code. This closes apache#7731.
tillrohrmann
force-pushed
the
removeJobManager
branch
from
c94e7a7 to
f2e0c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit removes the legacy
JobManagercomponent from Flink.This PR is based on #7725 and #7694.
Brief change log
TestingUtils#createJobManagerTestingJobManagerMessagesTestingJobManagerJobManagerVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation