Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Implement the object metadata compression protocol #1671

Open
Tracked by #1670
chaokunyang opened this issue Jun 3, 2024 · 0 comments
Open
Tracked by #1670

[JavaScript] Implement the object metadata compression protocol #1671

chaokunyang opened this issue Jun 3, 2024 · 0 comments

Comments

@chaokunyang
Copy link
Collaborator

chaokunyang commented Jun 3, 2024

Is your feature request related to a problem? Please describe.

Implement the object metadata compression protocol: type metadata encoding and parsing.

Describe the solution you'd like

#1556 can be taken as an example to type meta encoding.

Note that #1556 is only for type meta in java serialization, not for type encoding in java for xlang serialization

@chaokunyang chaokunyang changed the title Implement the object metadata compression protocol [JavaScript] Implement the object metadata compression protocol Jun 3, 2024
theweipeng pushed a commit that referenced this issue Jul 29, 2024
…ject Code Generation (#1774)

<!--
**Thanks for contributing to Fury.**

**If this is your first time opening a PR on fury, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**

Contribution Checklist

- The **Apache Fury (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).

- Fury has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->

## What does this PR do?

The `MetaString` class is introduced to handle Unicode encoding and
decoding for strings used in the code generation process for
`Type.Object`. This ensures that strings are properly encoded and
decoded during storage and transmission.

- **Encoding**: Converts Unicode strings into an encoded format.
- **Decoding**: Converts encoded strings back to their original Unicode
format.

The `MetaString` class is used in `object.ts` to handle string encoding
and decoding when generating code for `Type.Object`.


## Related issues

Is there any related issue? Please attach here.

- #1670
- #1671 
- #1674


## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

@theweipeng  Please have a look at my PR

## Benchmark

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant