-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added MetaString Class for Unicode Encoding/Decoding in Type.Object Code Generation #1774
Merged
+240
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed file extension to .ts
Changed file extension to .ts
Changed file extension to .ts
Removed MetaStringEncoder.ts
Forchapeatl
changed the title
Added MetaString Class for Unicode Encoding/Decoding in Type.Object Code Generation
feat: Added MetaString Class for Unicode Encoding/Decoding in Type.Object Code Generation
Jul 27, 2024
theweipeng
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
MetaString
class is introduced to handle Unicode encoding and decoding for strings used in the code generation process forType.Object
. This ensures that strings are properly encoded and decoded during storage and transmission.The
MetaString
class is used inobject.ts
to handle string encoding and decoding when generating code forType.Object
.Related issues
Is there any related issue? Please attach here.
Does this PR introduce any user-facing change?
@theweipeng Please have a look at my PR
Benchmark