GEODE-7294: Update dependencies for v1.11 #4104
Conversation
metatype
force-pushed
the
develop
branch
2 times, most recently
from
4907643 to
cc6663f
Compare
metatype
force-pushed
the
develop
branch
3 times, most recently
from
c6b66e9 to
40ea7d6
Compare
metatype
changed the title
|
@metatype LMK if you'd like some help fixing the failures. |
metatype
force-pushed
the
develop
branch
2 times, most recently
from
f43a294 to
3e5e3d6
Compare
| api(group: 'com.zaxxer', name: 'HikariCP', version: '3.2.0') | ||
| api(group: 'commons-beanutils', name: 'commons-beanutils', version: '1.9.3') | ||
| api(group: 'com.sun.istack', name: 'istack-commons-runtime', version: '3.0.9') | ||
| api(group: 'com.tngtech.archunit', name:'archunit-junit4', version: '0.11.0') |
There was a problem hiding this comment.
We're upgrading major versions of dependencies here, in the context of a minor of Geode. If we emit object from the packages as part of our API, then we might be breaking downstream clients.
There was a problem hiding this comment.
I think these should be safe to upgrade.
| @@ -24,7 +24,7 @@ dependencies { | |||
| compile(platform(project(':boms:geode-all-bom'))) | |||
| gradleLint.ignore { | |||
| // See GEODE-6128 -- ignore xml-apis in linter to avoid changes with every run. | |||
| upgradeTestCompile('xml-apis:xml-apis:1.4.01') | |||
| upgradeTestCompile('xml-apis:xml-apis:2.0.2') | |||
There was a problem hiding this comment.
Lets take this opportunity to move this version into our dependency manager, instead of being the sole hard-coded number.
| testCompile(group: 'net.sourceforge.pmd', name: 'pmd-test', version: '6.18.0') |
There was a problem hiding this comment.
Lets take this opportunity to move this version into our dependency manager, instead of being the sole hard-coded number.
metatype
force-pushed
the
develop
branch
2 times, most recently
from
e31c88c to
2eca393
Compare
I agree in principle, but I'd like to address that cleanup in a separate PR. |
I'm working on a timeout failure in AvailableConnectionManagerConcurrentTest. Currently trying to find the maximal set of upgrades that will pass tests. |
ghost
self-requested a review
Update as many dependencies as we can for v1.11. Since so many updates are included, please review the change set to see them all. Not *all* dependencies have been advanced; only the ones that seemed safest to do easily.
|
Closing this PR, superseded by newer work. |
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.