Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-7308: upgrade Jetty to a newer version #4166

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

mkevo
Copy link
Contributor

@mkevo mkevo commented Oct 16, 2019

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@metatype
Copy link
Contributor

On #4104 I skipped this upgrade because it was causing RestAPIsWithSSLDUnitTest to fail with a cert error. If you can figure that out it would be great!

@jdeppe-pivotal
Copy link
Contributor

@mkevo I think the SSL failures can be fixed by switching SSLContectFactory to SSLContextFactory.Server as per these Jetty issues:
jetty/jetty.project#3464
jetty/jetty.project#3466
jetty/jetty.project#3554

@mkevo
Copy link
Contributor Author

mkevo commented Oct 17, 2019

@mkevo I think the SSL failures can be fixed by switching SSLContectFactory to SSLContextFactory.Server as per these Jetty issues:
eclipse/jetty.project#3464
eclipse/jetty.project#3466
eclipse/jetty.project#3554

Thanks for an advice! I will take a look on it.

@jinmeiliao jinmeiliao merged commit 87d6726 into apache:develop Oct 22, 2019
@mkevo mkevo deleted the feature/GEODE-7308 branch October 23, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants