Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Build separate trino image for CI and client side. #1295

Closed
yuqi1129 opened this issue Jan 2, 2024 · 0 comments · Fixed by #1305
Closed

[Improvement] Build separate trino image for CI and client side. #1295

yuqi1129 opened this issue Jan 2, 2024 · 0 comments · Fixed by #1305
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jan 2, 2024

What would you like to be improved?

The Trino image for CI does not need to copy 'Gravitino-connector' into it and can mount the connector directory when running. However the image for client should include it, so we need to separate them.

Furthermore, this also results in #1278 failures.

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jan 2, 2024
@yuqi1129 yuqi1129 mentioned this issue Jan 3, 2024
Merged
jerryshao added a commit that referenced this issue Jan 5, 2024
@yuqi1129 @jerryshao
[#1295] improvement(CI): separate trino image for CI and users (#1305)
89955d3 
### What changes were proposed in this pull request?

Remove the Gravitino connector from the Trino CI image.

### Why are the changes needed?

In CI, we will mount the Gravitino connector to the Trino CI image to
test the latest code base, so we can fully test our PR.

Fix: #1295

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

---------

Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
github-actions bot pushed a commit that referenced this issue Jan 5, 2024
@yuqi1129 @jerryshao @web-flow
[#1295] improvement(CI): separate trino image for CI and users (#1305)
10e7333 
### What changes were proposed in this pull request?

Remove the Gravitino connector from the Trino CI image.

### Why are the changes needed?

In CI, we will mount the Gravitino connector to the Trino CI image to
test the latest code base, so we can fully test our PR.

Fix: #1295

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

---------

Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
@jerryshao jerryshao mentioned this issue Jan 5, 2024
Merged
yuqi1129 added a commit that referenced this issue Jan 5, 2024
@jerryshao @yuqi1129
[#1295] improvement(CI): separate trino image for CI and users (#1344)
c0509a0 
### What changes were proposed in this pull request?

Remove the Gravitino connector from the Trino CI image.

### Why are the changes needed?

In CI, we will mount the Gravitino connector to the Trino CI image to
test the latest code base, so we can fully test our PR.

Fix: #1295

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: Qi Yu <yuqi@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1295] improvement(CI): separate trino image for CI and users yuqi1129/gravitino
1 participant
@yuqi1129