Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1295] improvement(CI): separate trino image for CI and users #1344

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Remove the Gravitino connector from the Trino CI image.

Why are the changes needed?

In CI, we will mount the Gravitino connector to the Trino CI image to test the latest code base, so we can fully test our PR.

Fix: #1295

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

### What changes were proposed in this pull request?

Remove the Gravitino connector from the Trino CI image.

### Why are the changes needed?

In CI, we will mount the Gravitino connector to the Trino CI image to
test the latest code base, so we can fully test our PR.

Fix: #1295

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

---------

Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Jan 5, 2024
@jerryshao
Copy link
Contributor Author

@yuqi1129 can you please check the build issue here.

Copy link

github-actions bot commented Jan 5, 2024

Code Coverage Report

Overall Project 66.02% 🟢

There is no coverage information present for the Files changed

Copy link
Contributor

@diqiu50 diqiu50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit c0509a0 into branch-0.3 Jan 5, 2024
4 checks passed
@yuqi1129 yuqi1129 deleted the cherry-pick-branch-0.3-89955d326fff0332fdf0646841891ec1f5867fab branch January 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants