Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support Partition/Bucket/Sorting when creating Iceberg table by Trino #1511

Closed
Tracked by #1512
yuqi1129 opened this issue Jan 16, 2024 · 0 comments · Fixed by #1563
Closed
Tracked by #1512

[FEATURE] Support Partition/Bucket/Sorting when creating Iceberg table by Trino #1511

yuqi1129 opened this issue Jan 16, 2024 · 0 comments · Fixed by #1563
Assignees
@yuqi1129
Milestone
Gravitino 0.4.0

Comments

@yuqi1129
Copy link
Contributor

Describe the feature

Supports creating a Iceberg table with Partition/Bucket/Sorting by Trino.

Motivation

Please see above.

Describe the solution

Please see above.

Additional context

No response
This was referenced Jan 16, 2024
Closed
Merged
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 19, 2024
yuqi1129 added a commit that referenced this issue Jan 23, 2024
@yuqi1129
[#1511] feat(trino-connector): Support partition, distribution and so…
952afe4 
…rt order of Iceberg table created by Trino (#1563)

### What changes were proposed in this pull request?

We can create a Hive table with partitioning, distribution, and sorting
ordered by Trino.

### Why are the changes needed?

It's a crucial feature of the Trino connector.

Fix: #1511 

### Does this PR introduce _any_ user-facing change?

```text
trino:db1> create table t4(id int, name varchar) with (partitioning = ARRAY['name'], sorted_by = ARRAY['id']);
CREATE TABLE
trino:db1> show create table t4;
                 Create Table
----------------------------------------------
 CREATE TABLE "test.iceberg_catalog".db1.t4 (
    id integer,
    name varchar
 )
 COMMENT ''
 WITH (
    partitioning = ARRAY['name'],
    sorted_by = ARRAY['id']
 )
(1 row)

Query 20240117_092158_00001_qufcr, FINISHED, 1 node
Splits: 1 total, 1 done (100.00%)
1.08 [0 rows, 0B] [0 rows/s, 0B/s]
```


### How was this patch tested?

IT
@yuqi1129 yuqi1129 mentioned this issue Jan 23, 2024
Closed
mchades pushed a commit to mchades/gravitino that referenced this issue Jan 24, 2024
@yuqi1129 @mchades
[apache#1511] feat(trino-connector): Support partition, distribution …
eedf623 
…and sort order of Iceberg table created by Trino (apache#1563)

### What changes were proposed in this pull request?

We can create a Hive table with partitioning, distribution, and sorting
ordered by Trino.

### Why are the changes needed?

It's a crucial feature of the Trino connector.

Fix: apache#1511 

### Does this PR introduce _any_ user-facing change?

```text
trino:db1> create table t4(id int, name varchar) with (partitioning = ARRAY['name'], sorted_by = ARRAY['id']);
CREATE TABLE
trino:db1> show create table t4;
                 Create Table
----------------------------------------------
 CREATE TABLE "test.iceberg_catalog".db1.t4 (
    id integer,
    name varchar
 )
 COMMENT ''
 WITH (
    partitioning = ARRAY['name'],
    sorted_by = ARRAY['id']
 )
(1 row)

Query 20240117_092158_00001_qufcr, FINISHED, 1 node
Splits: 1 total, 1 done (100.00%)
1.08 [0 rows, 0B] [0 rows/s, 0B/s]
```


### How was this patch tested?

IT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
None yet
Projects
None yet
Milestone
Gravitino 0.4.0
2 participants
@jerryshao @yuqi1129