[#1511] feat(trino-connector): Support partition, distribution and sort order of Iceberg table created by Trino #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will convert this to a draft as it depends on issue #1455. |
# Conflicts: # catalogs/bundled-catalog/src/main/java/com/datastrato/catalog/property/PropertyConverter.java # common/src/main/java/com/datastrato/gravitino/dto/rel/PartitionUtils.java # integration-test/src/test/java/com/datastrato/gravitino/integration/test/trino/TrinoConnectorIT.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogConnectorMetadata.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveCatalogPropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveConnectorAdapter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveMetadataAdapter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HivePropertyMeta.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveSchemaPropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveTablePropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/SortingColumn.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/IcebergCatalogPropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/IcebergConnectorAdapter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/IcebergSchemaPropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/IcebergTablePropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/jdbc/JDBCCatalogPropertyConverter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/jdbc/mysql/MySQLConnectorAdapter.java # trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/jdbc/postgresql/PostgreSQLConnectorAdapter.java # trino-connector/src/test/java/com/datastrato/gravitino/trino/connector/catalog/hive/TestHiveCatalogPropertyConverter.java # trino-connector/src/test/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/TestIcebergCatalogPropertyConverter.java # trino-connector/src/test/java/com/datastrato/gravitino/trino/connector/catalog/jdbc/TestJDBCCatalogPropertyConverter.java
diqiu50
reviewed
Jan 23, 2024
...in/java/com/datastrato/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java
Show resolved
Hide resolved
diqiu50
reviewed
Jan 23, 2024
...n-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/00000_create_table.sql
Show resolved
Hide resolved
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jan 24, 2024
…and sort order of Iceberg table created by Trino (apache#1563) ### What changes were proposed in this pull request? We can create a Hive table with partitioning, distribution, and sorting ordered by Trino. ### Why are the changes needed? It's a crucial feature of the Trino connector. Fix: apache#1511 ### Does this PR introduce _any_ user-facing change? ```text trino:db1> create table t4(id int, name varchar) with (partitioning = ARRAY['name'], sorted_by = ARRAY['id']); CREATE TABLE trino:db1> show create table t4; Create Table ---------------------------------------------- CREATE TABLE "test.iceberg_catalog".db1.t4 ( id integer, name varchar ) COMMENT '' WITH ( partitioning = ARRAY['name'], sorted_by = ARRAY['id'] ) (1 row) Query 20240117_092158_00001_qufcr, FINISHED, 1 node Splits: 1 total, 1 done (100.00%) 1.08 [0 rows, 0B] [0 rows/s, 0B/s] ``` ### How was this patch tested? IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We can create a Hive table with partitioning, distribution, and sorting ordered by Trino.
Why are the changes needed?
It's a crucial feature of the Trino connector.
Fix: #1511
Does this PR introduce any user-facing change?
How was this patch tested?
IT