Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Avoid using system table for MySQL catalogs #2085

Closed
yuqi1129 opened this issue Feb 5, 2024 · 0 comments · Fixed by #2616
Closed

[Improvement] Avoid using system table for MySQL catalogs #2085

yuqi1129 opened this issue Feb 5, 2024 · 0 comments · Fixed by #2616
Assignees
@yuqi1129
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 5, 2024 •
edited
Loading

What would you like to be improved?

Some methods still require system tables to work well, such as MySQL database load method, we'd better avoid it.

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Feb 5, 2024
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Feb 20, 2024
@jerryshao jerryshao assigned yuqi1129 and unassigned Clearvive Mar 4, 2024
@yuqi1129 yuqi1129 mentioned this issue Mar 20, 2024
Merged
FANNG1 pushed a commit that referenced this issue Apr 9, 2024
@yuqi1129
[#2085] improvement(jdbc-mysql): Remove depends on JDBC system table. (…
5242e25 
…#2616)

### What changes were proposed in this pull request?

Use the JDBC connection meta to replace it with the JDBC system table to
obtain schema information.

### Why are the changes needed?

We shouldn't assume that we have access to system tables, which are
frequently protected by ACLs.

Fix: #2085 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Current tests can cover this changs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2085] improvement(jdbc-mysql): Remove depends on JDBC system table. yuqi1129/gravitino
3 participants
@jerryshao @yuqi1129 @Clearvive