[#2085] improvement(jdbc-mysql): Remove depends on JDBC system table. #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FANNG1 can you please help to review this. |
FANNG1
reviewed
Mar 21, 2024
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 21, 2024
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 21, 2024
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 22, 2024
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 22, 2024
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
|
@FANNG1 |
FANNG1
reviewed
Mar 27, 2024
.../src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlDatabaseOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Apr 8, 2024
...n/java/com/datastrato/gravitino/catalog/postgresql/operation/PostgreSqlSchemaOperations.java
Show resolved
Hide resolved
|
LGTM, except minor comment |
FANNG1
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the JDBC connection meta to replace it with the JDBC system table to obtain schema information.
Why are the changes needed?
We shouldn't assume that we have access to system tables, which are frequently protected by ACLs.
Fix: #2085
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Current tests can cover this changs.