HADOOP-19572. [ABFS][BugFix] Empty Page Issue on Subsequent ListBlob call with NextMarker #7698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| public List<FileStatus> postListProcessing(String relativePath, List<FileStatus> fileStatuses, | ||
| TracingContext tracingContext, URI uri) throws AzureBlobFileSystemException { | ||
| List<FileStatus> rectifiedFileStatuses = new ArrayList<>(); | ||
| if (fileStatuses.isEmpty() && !relativePath.equals(ROOT_PATH)) { |
Contributor
There was a problem hiding this comment.
!ROOT_PATH.equals(relativePath) for null safety
| // Root Always exists as directory. It can be an empty listing. | ||
| AbfsRestOperation pathStatus = this.getPathStatus(relativePath, tracingContext, null, false); | ||
| BlobListResultSchema listResultSchema = getListResultSchemaFromPathStatus(relativePath, pathStatus); | ||
| LOG.debug("ListStatus attempted on a file path. Returning file status."); |
Contributor
There was a problem hiding this comment.
Add path as well in the log
| return listResponseData; | ||
| } | ||
|
|
||
| @Override |
| } | ||
|
|
||
|
|
||
| @Override |
| public abstract ListResponseData listPath(String relativePath, boolean recursive, | ||
| int listMaxResults, String continuation, TracingContext tracingContext, URI uri) throws IOException; | ||
|
|
||
| public abstract ListResponseData listPath(String relativePath, boolean recursive, |
Contributor
There was a problem hiding this comment.
Please add java doc for wherever needed.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
manika137
reviewed
May 21, 2025
...-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java
Outdated
Show resolved
Hide resolved
manika137
reviewed
May 21, 2025
...-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
:::: AGGREGATED TEST RESULT :::: ============================================================
|
|
|
||
| public ListResponseData listPath(final String relativePath, final boolean recursive, | ||
| final int listMaxResults, final String continuation, TracingContext tracingContext, URI uri, boolean is404CheckRequired) | ||
| final int listMaxResults, final String continuation, TracingContext tracingContext, URI uri) |
Contributor
There was a problem hiding this comment.
The abstract listPath method in AbfsClient throws IOException, we should keep that exception same here as well.
Contributor
Author
There was a problem hiding this comment.
AzureBlobFileSystemException is IOException type only
| BlobListResultSchema listResultSchema = getListResultSchemaFromPathStatus(relativePath, pathStatus); | ||
| LOG.debug("ListBlob attempted on a file path. Returning file status."); | ||
| List<VersionedFileStatus> fileStatusList = new ArrayList<>(); | ||
| LOG.debug("ListStatus attempted on a file path {}. Returning file status.", relativePath); |
Contributor
There was a problem hiding this comment.
Correction in log message GetPathStatus attempted on the file path
Contributor
Author
There was a problem hiding this comment.
This is fine as originally ListStatus was attempted on file path.
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
anmolanmol1234
approved these changes
May 21, 2025
manika137
approved these changes
May 21, 2025
|
🎊 +1 overall
This message was automatically generated. |
anujmodi2021
added a commit
to ABFSDriver/AbfsHadoop
that referenced
this pull request
May 22, 2025
…call with NextMarker (apache#7698) Contributed by Anuj Modi Reviewed by Anmol Asrani, Manish Bhatt, Manika Joshi Signed off by Anuj Mod<anujmodi@apache.org>
anujmodi2021
added a commit
to ABFSDriver/AbfsHadoop
that referenced
this pull request
May 26, 2025
…call with NextMarker (apache#7698) Contributed by Anuj Modi Reviewed by Anmol Asrani, Manish Bhatt, Manika Joshi Signed off by Anuj Mod<anujmodi@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We came across a new behavior from the server where a ListBlob call can return an empty list even after returning a next marker(continuation token) from a previous list call.
This is to handle that case and do not imply listing to be incomplete.
How was this patch tested?
Existing Test Suite ran, and new tests are added.